From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20FC4C56202 for ; Wed, 18 Nov 2020 04:10:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2CAD22227 for ; Wed, 18 Nov 2020 04:10:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qx0xDJvK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727422AbgKREKz (ORCPT ); Tue, 17 Nov 2020 23:10:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726743AbgKREKy (ORCPT ); Tue, 17 Nov 2020 23:10:54 -0500 Received: from mail-oo1-xc44.google.com (mail-oo1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B89CC061A51 for ; Tue, 17 Nov 2020 20:10:54 -0800 (PST) Received: by mail-oo1-xc44.google.com with SMTP id c25so79682ooe.13 for ; Tue, 17 Nov 2020 20:10:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dRKcQO3pMtpF1NuRSX79Onpwrs+gklZx89qUCct/3SM=; b=qx0xDJvKIig0sy53FRoTJcfK5ApCXai9Xep4AiD5uw8cXKVPDQJuiOvTAKPirYWbK6 9uRC4oqhzurXiQqdPKA9npG9AFTdq5Vivhs2DXfQyNYtVokc+fIB/Y5T55L5n2XLjKWo h7JUwS7itLQITyiZRajejWqSlrJLdycOzUtIkvrJJpfZcpp6gqp0c15ew4e0PYxLr2/s JFHsfb5BjYhCMMEkUN/hF3VrftxD1WBc8tiw36P6gDNJDDpZBuzo1Ai+DxgcJar4Seba 1Fh9lslOMthE7PJESN3QIvxQz3MxHsgUhvjrtD3jaAZ/Gclo5uxQtduw5GxJRTrzYGZ6 aRKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dRKcQO3pMtpF1NuRSX79Onpwrs+gklZx89qUCct/3SM=; b=BhJuGnkjfqJOFkfBQwWqPO6/VKVsguhiwal8b6C1FEoyEfm5SjKfiyGAJ/vLR13z4w wlkN1DafaRwr4RO2SpCVnIMw9bZRoyJa+1kZ+6qWKBKm+hztse0wBpB/nUjyC7aNPdID 29s/MCEA3l+4zzKdYcCVo7FlAtwL7L4dEykrq/JJkXaxhGtYjzoaCKjqoktT6iPUreo9 o98i78Y+j/2DYWUEePHfG+Jz5mpKFXHYWtTdWcVUt/PuRnCR8kLaS5UmPG9DU7o/clxL nJTY4/bd7NTVbaGPOV2mrLZ+J1KovDSdrxW9YrIm2QVpFxb4yDu1BPrGkrnwamXakx0o 0K5w== X-Gm-Message-State: AOAM531vbi8Zaj6iivlNZZvz0p8XcROwtDP9sSOS3eww/ZmJbEgmKehl eLv3o0FzZVyX63V2rvFhSiVETw== X-Google-Smtp-Source: ABdhPJxl09WdJ1NQZeKYkxqPw0H5GKrDyLUScIS7dsPNwhLOqoUD1AyXq3vCWBh9+EB1kPR4vKnIfA== X-Received: by 2002:a4a:ddd7:: with SMTP id i23mr5416947oov.73.1605672653737; Tue, 17 Nov 2020 20:10:53 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id w22sm2446592oie.49.2020.11.17.20.10.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 20:10:53 -0800 (PST) Date: Tue, 17 Nov 2020 22:10:51 -0600 From: Bjorn Andersson To: Thara Gopinath Cc: agross@kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, robh+dt@kernel.org, sboyd@kernel.org, mturquette@baylibre.com, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 5/6] dts:qcom:sdm845: Add dt entries to support crypto engine. Message-ID: <20201118041051.GF8532@builder.lan> References: <20201117134714.3456446-1-thara.gopinath@linaro.org> <20201117134714.3456446-6-thara.gopinath@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117134714.3456446-6-thara.gopinath@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 17 Nov 07:47 CST 2020, Thara Gopinath wrote: > Add crypto engine (CE) and CE BAM related nodes and definitions to > "sdm845.dtsi". > > Signed-off-by: Thara Gopinath > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 30 ++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 40e8c11f23ab..b5b2ea97681f 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -2138,6 +2138,36 @@ ufs_mem_phy_lanes: lanes@1d87400 { > }; > }; > > + cryptobam: dma@1dc4000 { > + compatible = "qcom,bam-v1.7.0"; > + reg = <0 0x01dc4000 0 0x24000>; > + interrupts = ; > + clocks = <&rpmhcc RPMH_CE_CLK>; > + clock-names = "bam_clk"; > + #dma-cells = <1>; > + qcom,ee = <0>; > + qcom,controlled-remotely = <1>; > + iommus = <&apps_smmu 0x704 0x1>, > + <&apps_smmu 0x706 0x1>, > + <&apps_smmu 0x714 0x1>, > + <&apps_smmu 0x716 0x1>; Can you confirm that this can't be written as: iommus = <&apps_smmu 0x704 0x3>, <&apps_smmu 0x714 0x3>; (and same below). Regards, Bjorn > + }; > + > + crypto: crypto@1dfa000 { > + compatible = "qcom,crypto-v5.4"; > + reg = <0 0x01dfa000 0 0x6000>; > + clocks = <&gcc GCC_CE1_AHB_CLK>, > + <&gcc GCC_CE1_AHB_CLK>, > + <&rpmhcc RPMH_CE_CLK>; > + clock-names = "iface", "bus", "core"; > + dmas = <&cryptobam 6>, <&cryptobam 7>; > + dma-names = "rx", "tx"; > + iommus = <&apps_smmu 0x704 0x1>, > + <&apps_smmu 0x706 0x1>, > + <&apps_smmu 0x714 0x1>, > + <&apps_smmu 0x716 0x1>; > + }; > + > ipa: ipa@1e40000 { > compatible = "qcom,sdm845-ipa"; > > -- > 2.25.1 >