From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E0C1C5519F for ; Wed, 18 Nov 2020 13:50:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF3532065C for ; Wed, 18 Nov 2020 13:50:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jaAhxIS0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726624AbgKRNt6 (ORCPT ); Wed, 18 Nov 2020 08:49:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726601AbgKRNtz (ORCPT ); Wed, 18 Nov 2020 08:49:55 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FC0FC0613D4 for ; Wed, 18 Nov 2020 05:49:55 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id c9so3071833wml.5 for ; Wed, 18 Nov 2020 05:49:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=JPxBsG7pLUv1UeZC7bK3HiUpZwCt2ccyPS8zKWnix68=; b=jaAhxIS0kOFrub/2XYBkRaFdVAnK6ivWuYEyDekbW6fGKlwS+EgevqcDkbnpj78GsT W5C7DMKvp8x+kwJoYYxYP7SB0UfQseuhVjrNjHQbDktOvRNZVVcmqV6fasQrHRqbiM1V bt4uY2fSniJTFPq2hz8i2pOuDDnLwAeKCNGUSddr4CnzgKVe8xzzoWp+3hXjBQczi4Cn fNHbTMGz0Bd928VK7xb/I4v6wjsyBrAjU48L/olEJ03WtVcqtgs2ITvSw8mZdtBz2LmD bE5PJ1XT4pmgGXQwUusPBRV6MdX8PV22FfWopjaQIJgsYS0kAfuiIuitWyHzHNq54t4t /VPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=JPxBsG7pLUv1UeZC7bK3HiUpZwCt2ccyPS8zKWnix68=; b=pc8CKCZiRkWoVxTZbs7ddzHwpdBYlALyVluhPVnLW/tgDF54Buv/ID8CI9z+ssy+21 ZgGtqIf6vix5oe72A2K4qAhoDXPWRWQEiAr21MJIoVXEGLNAMSKClCRTZszTRBGbpHko HC4pEvRywHMyOPLk7hdtTd5dzarJXglFDWj66rD/QsxhnW54e5JgTcCHmSEnoBHkshaw F32FNIgeDwsT4IVKUilFS/I4BjiHHETjmGvrrz77oYC02KKVYdhhfHEiZwi0zzonfk1U 37mNc6F84b7SQV5SZdgf5/y7WycaUzdm0DoJ3HVuHU+jYKdTgev06ncXRTi4YEn4k6pa yIIA== X-Gm-Message-State: AOAM530tJSxpGvnWBQz/l6fRos9HJa9usylQ+Pe6GSCjK0XFyvvirRcm IZekF8dyUwi1KvMCmGdZce3yJCX/X/xJJvMu X-Google-Smtp-Source: ABdhPJyAMUqiNH0sMSJ+6gPz+g0YzrWzNKXgmPOPpNTTm967Lj9FBDf8f/eZpYPQ/PmJkINZJ39t2Q== X-Received: by 2002:a1c:a344:: with SMTP id m65mr112832wme.77.1605707394087; Wed, 18 Nov 2020 05:49:54 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n15sm33575358wrq.48.2020.11.18.05.49.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 05:49:53 -0800 (PST) Date: Wed, 18 Nov 2020 13:49:48 +0000 From: Lee Jones To: Soham Biswas Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , thierry.reding@gmail.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] pwm: core: Use octal permission Message-ID: <20201118134948.GS1869941@dell> References: <20201117175452.26914-1-sohambiswas41@gmail.com> <20201118104730.4270-1-sohambiswas41@gmail.com> <20201118124312.wk6cmnktxefn7k7m@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Nov 2020, Soham Biswas wrote: > Sure will do that. Sorry for the inconvenience, I am a bit new to the > process of emailing patches. Should I mark the next patch as v3? Make sure the text you are quoting does above your reply. This is called top-posting and is frowned upon. Yes, please bump the version number - it will make the tooling happy. > On Wed, 18 Nov 2020 at 18:13, Uwe Kleine-König > wrote: > > > > [added "v2" to the subject, would have been better if you had already > > done that. I don't know if/how this confuses tools like b4 and patchwork] > > > > Hello, > > > > On Wed, Nov 18, 2020 at 04:17:30PM +0530, Soham Biswas wrote: > > > Fixes the following warning generated by checkpatch: > > > > > > drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are > > > not preferred. Consider using octal permissions '0444'. > > > > > > +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL, > > > &pwm_debugfs_fops); > > > > something like: "Permission bits are easier readable in octal than with > > using the symbolic names." in the commit log would be good for those of > > us who missed why this was added to checkpatch. > > > > Best regards > > Uwe > > > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog