From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62614C63798 for ; Wed, 18 Nov 2020 14:47:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01A7E246EA for ; Wed, 18 Nov 2020 14:47:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ncYrEBRu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727167AbgKROq7 (ORCPT ); Wed, 18 Nov 2020 09:46:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727158AbgKROq6 (ORCPT ); Wed, 18 Nov 2020 09:46:58 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D14AC0613D6 for ; Wed, 18 Nov 2020 06:46:58 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id u12so2528607wrt.0 for ; Wed, 18 Nov 2020 06:46:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=IkaU1T+8H3BSMi/OZIdt01pC83gmWoA2b6gexN813gY=; b=ncYrEBRufOu2pip0jWLcl1ef6oGqS09gWhOhJ54VF5gFdvFz8zZ7Y9BBqOLCibxWZ5 1E7o5Khplrmn0qpZHHAvp8BeDAwF4wyH/2a12MXy+zEonpCvZJLEs7RKlwrcm/JDVmy/ Q85s7aTQi9nz8v/7Uv0kp0Rh+M61lgBVlp6oUWThWXhPCyW+hKuunIqbpCn8/8xtQCdR bOuIoH07zddGkhTqGlsdrITJVuZDTFYfzSC0gOSy0YN2vLGWGXZUB5XWicp6PYXO/Q26 a55X4smDs3jwpOOIL9zy1BJRBOp2allN5kQyoZkcTwRlxjeqlzX7gpsCo936vL4EzikH Vv9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=IkaU1T+8H3BSMi/OZIdt01pC83gmWoA2b6gexN813gY=; b=Obrd7CSU846DGhlrOVWlhXL+Y/Pi1Ap+9H+D8uS064usk0+N+rVxAfOkzFGCzYPozk /7WkIjJ5omiB8GuhR+KtboV8boVPUZOA2ohCHvDe4rhOJrn6nb0oDbI94lRUmn4SORoP AI3avDpxH5dY5LnLj7lxJyC0egNG/omf+Muvn9cvjPCZoE1GJQZZJk8bkTcTo2hcHRR4 8Zyi0uNHnpdJmS1J6cYzKG4K+v3PHcoGUjNfU+rjabJFGwoxZ8xOKlHPOLqBgsKfB1d1 IT3utAWzbzHWEZrZo3AgFmGzasD1V7toPMB5iYBW/t/9LYAf5effQ+z4bf0Yip7TpG9v ExYg== X-Gm-Message-State: AOAM5331OTpQlRzZhDv4PiXlihZbvLGP+fdLEWyPxVw359eToCdtsUwu lrlIFgV0MoeVq4uBzlHYA+nSIw== X-Google-Smtp-Source: ABdhPJzmCg5rGmPl3TA4ofbkxIQA12zKJc4EMI8YdvXMd2K0LqWAP1eAwQh3GbWsxulnG/d1QlP1PQ== X-Received: by 2002:a05:6000:182:: with SMTP id p2mr5587590wrx.116.1605710817217; Wed, 18 Nov 2020 06:46:57 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id t20sm97700wmi.3.2020.11.18.06.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 06:46:56 -0800 (PST) Date: Wed, 18 Nov 2020 14:46:54 +0000 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Soham Biswas , thierry.reding@gmail.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pwm: core: Use octal permission Message-ID: <20201118144654.GU1869941@dell> References: <20201117175452.26914-1-sohambiswas41@gmail.com> <20201118135835.18395-1-sohambiswas41@gmail.com> <20201118142156.uf5bfzq3sh3gliik@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201118142156.uf5bfzq3sh3gliik@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Nov 2020, Uwe Kleine-König wrote: > On Wed, Nov 18, 2020 at 07:36:28PM +0530, Soham Biswas wrote: > > On Wed, 18 Nov 2020 at 19:29, Soham Biswas wrote: > > > > > > Permission bits are easier readable in octal than with using the symbolic names. > > > > > > Fixes the following warning generated by checkpatch: > > > > > > drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. > > > Consider using octal permissions '0444'. > > > > > > +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL, > > > &pwm_debugfs_fops); > > > > > > Signed-off-by: Soham Biswas > > > --- > > > drivers/pwm/core.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c > > > index 1f16f5365d3c..a8eff4b3ee36 100644 > > > --- a/drivers/pwm/core.c > > > +++ b/drivers/pwm/core.c > > > @@ -1338,7 +1338,7 @@ DEFINE_SEQ_ATTRIBUTE(pwm_debugfs); > > > > > > static int __init pwm_debugfs_init(void) > > > { > > > - debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL, > > > + debugfs_create_file("pwm", S_IFREG | 0444, NULL, NULL, > > > &pwm_debugfs_fops); > > > > > > return 0; > > > > > > > I passed -v3 to git-send-email but it didn't work it seems. > > It only works if you use it with a commit range I guess, i.e. when it > calls git-format-patch itself. > > Also I think if you call checkpatch on your own patch (e.g. using: > > git format-patch -v3 --stdout | scripts/checkpatch.pl > > ) it will tell you to break the long line in the commit log. That's funny! Although you can safely ignore that one. I find it's better to keep errors/warnings whole. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog