From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5011C5519F for ; Wed, 18 Nov 2020 15:26:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68CDE24766 for ; Wed, 18 Nov 2020 15:26:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727296AbgKRP04 (ORCPT ); Wed, 18 Nov 2020 10:26:56 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:33161 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgKRP0z (ORCPT ); Wed, 18 Nov 2020 10:26:55 -0500 X-Originating-IP: 86.194.74.19 Received: from localhost (lfbn-lyo-1-997-19.w86-194.abo.wanadoo.fr [86.194.74.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 0D22624000C; Wed, 18 Nov 2020 15:26:52 +0000 (UTC) Date: Wed, 18 Nov 2020 16:26:52 +0100 From: Alexandre Belloni To: Ludovic Desroches Cc: cristian.birsan@microchip.com, nicolas.ferre@microchip.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 0/3] ARM: dts: at91: add pincontrol node for USB Host Message-ID: <20201118152652.GA11581@piout.net> References: <20201118120019.1257580-1-cristian.birsan@microchip.com> <20201118150336.g3u3ljuhrbrn2cko@sekiro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201118150336.g3u3ljuhrbrn2cko@sekiro> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 18/11/2020 16:03:36+0100, Ludovic Desroches wrote: > At first glance, there is no trivial way to register the pin range in the > pinctrl-at91 driver. There is one driver for the pinctrl and one for the gpio. > I am open to suggestions to fix it in the pinctrl-at91 driver as well if there > is an elegant way (I have some in mind, but there are not) without having to > refactor the driver. > But shouldn't that driver be refactored at some point anyway? I know you are moving away with new SoCs but it causes real issues. For example, gpio hogs are not working, this is impacting some of your customers. The other thing is the weird probe order preventing a nice cleanup of the platform code. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com