From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B698C63798 for ; Wed, 18 Nov 2020 15:38:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0F5B24779 for ; Wed, 18 Nov 2020 15:38:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727448AbgKRPiV (ORCPT ); Wed, 18 Nov 2020 10:38:21 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:58261 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726495AbgKRPiU (ORCPT ); Wed, 18 Nov 2020 10:38:20 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 79F895803C7; Wed, 18 Nov 2020 10:38:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 18 Nov 2020 10:38:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=jiFRinBhroU8gF2dg+tsxbq0jYn 80Lj5IEmgVTmjZxQ=; b=fVm7YQ8jpspmpzPYfV/ipmzCzVB77F1xuT0tVIAL222 sWkdad23hFwGGBOjR/DsrS4ToGE2s6dgJ4mCifZkVTC+5CxV2nRvi3Fy3PLLtiKc A6BxyThaixitas2h07F7QU+PWkjLLqcDXTEzXp33QLXrujnaoK2k/vPHbTWSHDkR sm8xpp+xDNwndRn++5soUOffme25aXRqGuwsRdaXP9112HRwyCskbf9e2o3W5XIB ywCxcovtVSmE6HUMVPnDeajtGBOcqNxLKUzo9/0/X9qclG8XzVft8qm6yN7MThig D98YndIEmJ0b3HK2Pc88jzsa2nmKaPD6zJD2Q0pTWew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=jiFRin BhroU8gF2dg+tsxbq0jYn80Lj5IEmgVTmjZxQ=; b=TqhBKuNe1VVa182VvJuctB bvbOXPFd7bqpiYPdAtuNw3jtU5FKFaoD60wB40xJo6S5fFZt2k/ic02lBo8fc9CS rvWQVy6Po/LEFGS+QSffxfPj3rwgpUuzIbLhV4BclAa3UeyD7vJSFzeUauspxjyy zTd6YI1pnhcAlh0qsZJj+PA5RZjp6pI8I7chd3NWThENGapjWaX7Mx/QUlRtnQHY zdUVn/OnZ04ujZEFw5Qm954gLqAVY/WygagJvLSUwWMkJKzRpiNMYnw/uRQx7imo vk1ROKIusbKWoL8ShMFu2qpY6626xdR2OxHL+pkZoRsw2OiOhy7PxXsZKr5grdwQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefhedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id B1AF93064AAF; Wed, 18 Nov 2020 10:38:17 -0500 (EST) Date: Wed, 18 Nov 2020 16:38:16 +0100 From: Maxime Ripard To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: sunxi: do not select COMMON_CLK to fix builds Message-ID: <20201118153816.fctrz6dfjiph2mgl@gilmour.lan> References: <20201117182310.73609-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x6ukipbmjbi6ayno" Content-Disposition: inline In-Reply-To: <20201117182310.73609-1-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --x6ukipbmjbi6ayno Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 17, 2020 at 07:23:10PM +0100, Krzysztof Kozlowski wrote: > COMMON_CLK is a user-selectable option with its own dependencies. The > most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers > should not select COMMON_CLK because they will create a dependency cycle > and build failures. For example on MIPS a configuration with COMMON_CLK > (selected by SND_SUN8I_CODEC) and HAVE_LEGACY_CLK (selected by > SOC_RT305X) is possible: >=20 > WARNING: unmet direct dependencies detected for COMMON_CLK > Depends on [n]: !HAVE_LEGACY_CLK [=3Dy] > Selected by [y]: > - SND_SUN8I_CODEC [=3Dy] && SOUND [=3Dy] && !UML && SND [=3Dy] && SND= _SOC [=3Dy] && > (ARCH_SUNXI || COMPILE_TEST [=3Dy]) && OF [=3Dy] && (MACH_SUN8I || = ARM64 && ARCH_SUNXI || COMPILE_TEST [=3Dy]) >=20 > /usr/bin/mips-linux-gnu-ld: drivers/clk/clk.o: in function `clk_set_r= ate': > (.text+0xaeb4): multiple definition of `clk_set_rate'; arch/mips/rali= nk/clk.o:(.text+0x88): first defined here >=20 > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Samuel Holland Acked-by: Maxime Ripard however, I'm not sure the prefix is the one Mark would expect? Maxime --x6ukipbmjbi6ayno Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX7U/6AAKCRDj7w1vZxhR xUOAAP48nXr96GGEF754GEu/aKJQDqP5hJ6/mTDONuk2RUglHgD/Zdrpl1dzj8xT QlREWW9yHK4WzcLL4dqiaF1XVhXliQI= =47Fl -----END PGP SIGNATURE----- --x6ukipbmjbi6ayno--