From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: ohad@wizery.com, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
agross@kernel.org, evgreen@chromium.org
Subject: Re: [PATCH 1/2] remoteproc: qcom_q6v5_mss: Replace ioremap with memremap
Date: Wed, 18 Nov 2020 11:58:15 -0600 [thread overview]
Message-ID: <20201118175815.GE9177@builder.lan> (raw)
In-Reply-To: <1604473422-29639-1-git-send-email-sibis@codeaurora.org>
On Wed 04 Nov 01:03 CST 2020, Sibi Sankar wrote:
> Fix the sparse warnings reported by the kernel test bot by replacing
> ioremap calls with memremap.
>
> Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
>
> I'll send out the patches to convert ioremap to memremap on other
> qc remoteproc drivers once I get a chance to test them.
>
> drivers/remoteproc/qcom_q6v5_mss.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index 9a473cfef758..2c866b6da23c 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -1194,7 +1194,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
> goto release_firmware;
> }
>
> - ptr = ioremap_wc(qproc->mpss_phys + offset, phdr->p_memsz);
> + ptr = memremap(qproc->mpss_phys + offset, phdr->p_memsz, MEMREMAP_WC);
> if (!ptr) {
> dev_err(qproc->dev,
> "unable to map memory region: %pa+%zx-%x\n",
> @@ -1209,7 +1209,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
> "failed to load segment %d from truncated file %s\n",
> i, fw_name);
> ret = -EINVAL;
> - iounmap(ptr);
> + memunmap(ptr);
> goto release_firmware;
> }
>
> @@ -1221,7 +1221,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
> ptr, phdr->p_filesz);
> if (ret) {
> dev_err(qproc->dev, "failed to load %s\n", fw_name);
> - iounmap(ptr);
> + memunmap(ptr);
> goto release_firmware;
> }
>
> @@ -1232,7 +1232,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
> memset(ptr + phdr->p_filesz, 0,
> phdr->p_memsz - phdr->p_filesz);
> }
> - iounmap(ptr);
> + memunmap(ptr);
> size += phdr->p_memsz;
>
> code_length = readl(qproc->rmb_base + RMB_PMI_CODE_LENGTH_REG);
> @@ -1299,11 +1299,11 @@ static void qcom_q6v5_dump_segment(struct rproc *rproc,
> }
>
> if (!ret)
> - ptr = ioremap_wc(qproc->mpss_phys + offset + cp_offset, size);
> + ptr = memremap(qproc->mpss_phys + offset + cp_offset, size, MEMREMAP_WC);
>
> if (ptr) {
> memcpy(dest, ptr, size);
> - iounmap(ptr);
> + memunmap(ptr);
> } else {
> memset(dest, 0xff, size);
> }
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
prev parent reply other threads:[~2020-11-18 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 7:03 [PATCH 1/2] remoteproc: qcom_q6v5_mss: Replace ioremap with memremap Sibi Sankar
2020-11-04 7:03 ` [PATCH 2/2] remoteproc: qcom_q6v5_mss: map/unmap MBA region before/after use Sibi Sankar
2020-11-24 16:22 ` Bjorn Andersson
2020-11-18 17:58 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118175815.GE9177@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox