From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D75BC56202 for ; Wed, 18 Nov 2020 17:59:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1EB922210 for ; Wed, 18 Nov 2020 17:59:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K8uCnzo+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726107AbgKRR7l (ORCPT ); Wed, 18 Nov 2020 12:59:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgKRR7k (ORCPT ); Wed, 18 Nov 2020 12:59:40 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA37EC0613D4; Wed, 18 Nov 2020 09:59:40 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id c198so2017171wmd.0; Wed, 18 Nov 2020 09:59:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jE6xH3xJT8t3bwjXvLY5varaGvrj90mEqWVft4kIEmo=; b=K8uCnzo+I6QMN8j4L73XC+Q+vWAjDrHlQkHZvObSTdMsxU6SGwz6pxgSsEurOJPbjq HS/TlvzeNIKuprXTIrh6JnzPpSBFZAxnGxpne+mUiV5sZkZkvEIdIquzazv8pxQyiM6b WCwkA4sa69/9qBAr1MwUx9/7H65puByUducCUc87tfZe1qtNMqQoN+7lPvFkIZyOuzi5 ctXKnSfO8p7J4JcuTmrMpKaOYiTrLuB2gLe7XZKEwB4sH1BeG7oQ3E6cgFt+7pLCeEHf ftCjGYIpwZJjTET1NvI1kOBDmE/aiV9V2sJdKF9SySPf0sUx0NnXw0JvBeM28NypGgfj NEnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jE6xH3xJT8t3bwjXvLY5varaGvrj90mEqWVft4kIEmo=; b=ToQjYv4wtceLG25X4JWpePMz7EVArgn9vpt8284TU7rMfYQucml04HKL4UAo9VMBUC bMU6FpbMWwF1iIebMDNysHUbws5H0d5Jq2S4nUsXBadeLStx2q0r3T/kz78in7Idh4o7 s0KegzeKFXg1kTIy4nTfR/5grV7278IsH6GKbn48Gs436mhinFw8M9aI8RUU/HanJG1V jDWNTnlHnctvNgepI5kpvPEtrWqe0DnhaZbGNgHDZ0SzFMaPjB3X/meG6O1+fswkiY29 18uUplYbutl1psjyHvNhwfWCb3aKNY4AdWUMVneHCWOZab3PUloXyIsW5VoOzK7fnn9n zxFw== X-Gm-Message-State: AOAM5313QwnqkC6EV7T4ZuWMj/jMczHxXPplqvW5W322h3c/dC3GkZn6 pgqEEo1qD+NxaiXVA8hkt6M= X-Google-Smtp-Source: ABdhPJzHYJVIqxKzrw2tN2VVzJXDmNacwF8gO8cKfA+DGUCUkw6UdYvqBWrcXYN2JGziNk14njIYQA== X-Received: by 2002:a1c:2384:: with SMTP id j126mr318789wmj.116.1605722379424; Wed, 18 Nov 2020 09:59:39 -0800 (PST) Received: from localhost ([217.111.27.204]) by smtp.gmail.com with ESMTPSA id a21sm617367wmb.38.2020.11.18.09.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 09:59:38 -0800 (PST) Date: Wed, 18 Nov 2020 18:59:36 +0100 From: Thierry Reding To: Soham Biswas Cc: lee.jones@linaro.org, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] pwm: core: Use octal permission Message-ID: <20201118175936.GB3552669@ulmo> References: <20201117175452.26914-1-sohambiswas41@gmail.com> <20201118145112.21250-1-sohambiswas41@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yNb1oOkm5a9FJOVX" Content-Disposition: inline In-Reply-To: <20201118145112.21250-1-sohambiswas41@gmail.com> User-Agent: Mutt/1.14.7 (2020-08-29) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yNb1oOkm5a9FJOVX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 18, 2020 at 08:21:12PM +0530, Soham Biswas wrote: > Permission bits are easier readable in octal than with using the > symbolic names. >=20 > Fixes the following warning generated by checkpatch: >=20 > drivers/pwm/core.c:1341: WARNING: Symbolic permissions 'S_IRUGO' are > not preferred. Consider using octal permissions '0444'. >=20 > +debugfs_create_file("pwm", S_IFREG | S_IRUGO, NULL, NULL, > &pwm_debugfs_fops); >=20 > Signed-off-by: Soham Biswas > --- > drivers/pwm/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Though I did unwrap the checkpatch warning message as Uwe suggested. Thierry --yNb1oOkm5a9FJOVX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+1YQgACgkQ3SOs138+ s6EzahAAtvL172oAjP8DMdC4bZL1n1WrGgaPfOOA03IUuaZiYFFQu9/V5UaMa7zk jNEYlPHuGGeiRXRhCgOU6loZGiy9pH6/72+cE/y5QBK0azDxk9IT+bnlMnRu13UV soab0bFyTkg1skm2Iome7DGxuxoL7baxeZZvdXHFD8zGgYa8uIyHDJBClDe9Zu1Z VgWfPG4Cy0ch18TCCJQg29M1cpZwDqLcEI0BBmHVEAmT64+6epNudrslnTEQTyyM XkRcq6Fa1U2AHNyy0v/PF+RZbhAcO0FElxYTvKKa6UPzqjkDmlUqGyQ8kuHmmRJg 0jD4R6nJjLjOA3AOqcG6ZqrfIQ5RaEvELZYn4m3XOJej+oprQvKcpdSnsq+KREyd W0CSCb9SfqXZAAIM0m1E40c4NReaubbQaDeNMMhRrWbmq1UMmogVyomiRyGdLLe9 ASlCGk08Ks0KlkJ+HbKTQ2/hVYtOt0neJuv0BnpCbP2dcPEQZO35RM1KoZTwIyFW UF+AKeALMLjmEjDzbrA6YD9aK9bcqxRe+1b4ikjYV4Rb5L2n8Hh3Taxpn/mH08hs mMwtUka/giwkuoXNNmHIJV4beH+kdXw9VljAG+PaKyQSaNwRrOwkns+X+7f28nZJ ZBTHGHA7Z7NFO6L4jtwfXMKyLrRWPQ3DhFxKbYeyISSWqlMCk9g= =gkhH -----END PGP SIGNATURE----- --yNb1oOkm5a9FJOVX--