Re: [PATCH v2 4/4] iio: hid-sensors: Add hinge sensor driver

Ye, Xiang
2020-11-25T02:38:04Z

Hi,

On Tue, Nov 24, 2020 at 11:39:51AM +0000, Jonathan Cameron wrote:
>
> > >
> > > > +
> > > > + To compile this driver as a module, choose M here: the
> > > > + module will be called hid-sensor-custom-hinge.
> > > > +
> > > > endmenu
> > > > diff --git a/drivers/iio/position/Makefile b/drivers/iio/position/Makefile
> > > > index 3cbe7a734352..7a6225977a01 100644
> > > > --- a/drivers/iio/position/Makefile
> > > > +++ b/drivers/iio/position/Makefile
> > > > @@ -5,3 +5,6 @@
> > > > # When adding new entries keep the list in alphabetical order
> > > >
> > > > obj-$(CONFIG_IQS624_POS) += iqs624-pos.o
> > > > +
> > > > +obj-$(CONFIG_HID_SENSOR_CUSTOM_HINGE) += hid-sensor-custom-hinge.o
> > >
> > > Alphabetical order preferred.
> > >
> > > > +ccflags-y += -I$(srctree)/drivers/iio/common/hid-sensors
> > >
> > > Why?
> > hinge driver need to include #include "hid-sensor-trigger.h", if not using this cflag-y
> > it should be #include "../common/hid-sensors/hid-sensor-trigger.h"
>
> Even though that looks a bit ugly, I'd prefer that rather than having to realize we
> were doing something not entirely obvious in the Makefile.
Okay, will remove ccflags-y in the makefile

Thanks
Ye, Xiang
>
> Thanks,
>
> Jonathan