public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
To: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	"ohad@wizery.com" <ohad@wizery.com>,
	"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
	"linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 8/8] rpmsg: Turn name service into a stand alone driver
Date: Thu, 19 Nov 2020 18:10:51 +0100	[thread overview]
Message-ID: <20201119171051.GA6464@ubuntu> (raw)
In-Reply-To: <447fdbd6-2e3d-2786-c444-25148efcb9f8@st.com>

Hi Mathieu,

I haven't tested it yet, but I've compared it to the previous version 
and all the changed except the one, mentioned by Arnaud, seem to be 
there! So, let's just fix this one and should be good to go!

Thanks
Guennadi

On Thu, Nov 19, 2020 at 03:52:50PM +0100, Arnaud POULIQUEN wrote:

[snip]

> As Guennadi mentionned in a previous mail
> a kfree(vch) is missing on error
> 
> @@ -949,10 +949,11 @@ static int rpmsg_probe(struct virtio_device *vdev)
>  	dev_info(&vdev->dev, "rpmsg host is online\n");
> 
>  	return 0;
> 
>  free_coherent:
> +	kfree(vch);
>  	dma_free_coherent(vdev->dev.parent, total_buf_space,
>  			  bufs_va, vrp->bufs_dma);
>  vqs_del:
> 
> Otherwise i tested this series successfully.
> 
> Thanks,
> Arnaud

  reply	other threads:[~2020-11-19 17:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18 21:36 [PATCH v6 0/8] rpmsg: Make RPMSG name service modular Mathieu Poirier
2020-11-18 21:36 ` [PATCH v6 1/8] rpmsg: Introduce __rpmsg{16|32|64} types Mathieu Poirier
2020-11-18 21:36 ` [PATCH v6 2/8] rpmsg: virtio: Move from virtio to rpmsg byte conversion Mathieu Poirier
2020-11-18 21:36 ` [PATCH v6 3/8] rpmsg: Move structure rpmsg_ns_msg to header file Mathieu Poirier
2020-11-18 21:36 ` [PATCH v6 4/8] rpmsg: virtio: Rename rpmsg_create_channel Mathieu Poirier
2020-11-18 21:36 ` [PATCH v6 5/8] rpmsg: core: Add channel creation internal API Mathieu Poirier
2020-11-18 21:36 ` [PATCH v6 6/8] rpmsg: virtio: Add rpmsg channel device ops Mathieu Poirier
2020-11-18 21:36 ` [PATCH v6 7/8] rpmsg: Make rpmsg_{register|unregister}_device() public Mathieu Poirier
2020-11-18 21:37 ` [PATCH v6 8/8] rpmsg: Turn name service into a stand alone driver Mathieu Poirier
2020-11-19 14:52   ` Arnaud POULIQUEN
2020-11-19 17:10     ` Guennadi Liakhovetski [this message]
2020-11-19 17:33       ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119171051.GA6464@ubuntu \
    --to=guennadi.liakhovetski@linux.intel.com \
    --cc=arnaud.pouliquen@st.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox