public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>, Andi Kleen <ak@linux.intel.com>,
	Rafael Aquini <aquini@redhat.com>,
	Waiman Long <longman@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] x86: restore the write back cache of reserved RAM in iounmap()
Date: Thu, 19 Nov 2020 18:02:06 +0000	[thread overview]
Message-ID: <20201119180206.GA24054@infradead.org> (raw)
In-Reply-To: <20201119175902.17394-1-aarcange@redhat.com>

On Thu, Nov 19, 2020 at 12:59:01PM -0500, Andrea Arcangeli wrote:
> Hello everyone,
> 
> We identified some PCD set on the direct mapping causing hardly
> reproducible performance issues and this patch fixes the ultimate root
> cause.
> 
> The caller for now has been tweaked to avoid triggering this case (now
> that we know about it)

What is the callers?  The whole SetPageReservered + ioremap* thing
you mention in the actual patch is completely bogus.  I think we'll
need to reject that as well and fix the caller.

  parent reply	other threads:[~2020-11-19 18:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 17:59 [PATCH 0/1] x86: restore the write back cache of reserved RAM in iounmap() Andrea Arcangeli
2020-11-19 17:59 ` [PATCH 1/1] " Andrea Arcangeli
2020-11-19 21:01   ` Thomas Gleixner
2020-11-19 18:02 ` Christoph Hellwig [this message]
2020-11-19 19:03   ` [PATCH 0/1] " Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119180206.GA24054@infradead.org \
    --to=hch@infradead.org \
    --cc=aarcange@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=aquini@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox