Re: [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring

Tao Ren
2020-11-19T07:22:37Z

On Wed, Nov 18, 2020 at 05:26:53PM -0800, Guenter Roeck wrote:
> On Wed, Nov 18, 2020 at 05:01:19PM -0800, Guenter Roeck wrote:
> > On Wed, Nov 18, 2020 at 03:42:53PM -0800, Tao Ren wrote:
> > > On Thu, Nov 19, 2020 at 12:27:19AM +0100, Andrew Lunn wrote:
> > > > On Wed, Nov 18, 2020 at 03:09:27PM -0800, rentao.bupt@gmail.com wrote:
> > > > > From: Tao Ren <rentao.bupt@gmail.com>
> > > > >
> > > > > The patch series adds hardware monitoring driver for the Maxim MAX127
> > > > > chip.
> > > >
> > > > Hi Tao
> > > >
> > > > Why are using sending a hwmon driver to the networking mailing list?
> > > >
> > > > Andrew
> > >
> > > Hi Andrew,
> > >
> > > I added netdev because the mailing list is included in "get_maintainer.pl
> > > Documentation/hwmon/index.rst" output. Is it the right command to find
> > > reviewers? Could you please suggest? Thank you.
> >
> > I have no idea why running get_maintainer.pl on
> > Documentation/hwmon/index.rst returns such a large list of mailing
> > lists and people. For some reason it includes everyone in the XDP
> > maintainer list. If anyone has an idea how that happens, please
> > let me know - we'll want to get this fixed to avoid the same problem
> > in the future.
> >
>
> I found it. The XDP maintainer entry has:
>
> K: xdp
>
> This matches Documentation/hwmon/index.rst.
>
> $ grep xdp Documentation/hwmon/index.rst
> xdpe12284
>
> It seems to me that a context match such as "xdp" in MAINTAINERS isn't
> really appropriate. "xdp" matches a total of 348 files in the kernel.
> The large majority of those is not XDP related. The maintainers
> of XDP (and all the listed mailing lists) should not be surprised
> to get a large number of odd review requests if they want to review
> every single patch on files which include the term "xdp".
>
> Guenter

Thanks Guenter and Andrew. Given xdp maintainers were included by
mistake, I will remove them from the future discussions of this hwmon
patch series.

Cheers,

Tao