* [PATCH] mmc: tmio: do not print real IOMEM pointer
@ 2020-11-16 16:42 Krzysztof Kozlowski
2020-11-20 9:44 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-16 16:42 UTC (permalink / raw)
To: Wolfram Sang, Ulf Hansson, linux-mmc, linux-kernel
Cc: Dan Carpenter, kbuild-all, Krzysztof Kozlowski, kernel test robot
Printing kernel pointers is discouraged because they might leak kernel
memory layout. This fixes smatch warning:
drivers/mmc/host/tmio_mmc.c:177 tmio_mmc_probe() warn: argument 3 to %08lx specifier is cast from pointer
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/mmc/host/tmio_mmc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
index d2d3b8df1bbe..b55a29c53d9c 100644
--- a/drivers/mmc/host/tmio_mmc.c
+++ b/drivers/mmc/host/tmio_mmc.c
@@ -174,8 +174,7 @@ static int tmio_mmc_probe(struct platform_device *pdev)
if (ret)
goto host_remove;
- pr_info("%s at 0x%08lx irq %d\n", mmc_hostname(host->mmc),
- (unsigned long)host->ctl, irq);
+ pr_info("%s at 0x%p irq %d\n", mmc_hostname(host->mmc), host->ctl, irq);
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mmc: tmio: do not print real IOMEM pointer
2020-11-16 16:42 [PATCH] mmc: tmio: do not print real IOMEM pointer Krzysztof Kozlowski
@ 2020-11-20 9:44 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2020-11-20 9:44 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ulf Hansson, linux-mmc, linux-kernel, Dan Carpenter, kbuild-all,
kernel test robot
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
On Mon, Nov 16, 2020 at 05:42:52PM +0100, Krzysztof Kozlowski wrote:
> Printing kernel pointers is discouraged because they might leak kernel
> memory layout. This fixes smatch warning:
>
> drivers/mmc/host/tmio_mmc.c:177 tmio_mmc_probe() warn: argument 3 to %08lx specifier is cast from pointer
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-20 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-16 16:42 [PATCH] mmc: tmio: do not print real IOMEM pointer Krzysztof Kozlowski
2020-11-20 9:44 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox