From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FEB0C56201 for ; Sun, 22 Nov 2020 04:45:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 027992078E for ; Sun, 22 Nov 2020 04:45:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LhkL/kdy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727266AbgKVEol (ORCPT ); Sat, 21 Nov 2020 23:44:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727220AbgKVEok (ORCPT ); Sat, 21 Nov 2020 23:44:40 -0500 Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69877C0613CF for ; Sat, 21 Nov 2020 20:44:40 -0800 (PST) Received: by mail-ot1-x344.google.com with SMTP id o3so12825364ota.8 for ; Sat, 21 Nov 2020 20:44:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ofKTU8s93Yu2rM/fmGaOrrNeXKEZaodPNsHLyk7YFKc=; b=LhkL/kdyA5u95rH07pm/9mhJeB0WBhvhTtcGxY3w7nA40Rb7/tKY/SEvi2brBOO2b2 yL0LLjPcEpenC0C8UcwXjtO4tDg29+JUIJO6Fr4LLctEKdCL68wVoihefre/nVFMTTgK t9TDVRa5Lp2x21kJd3tdJ8JKXVjw2a0ELRISJfn9kTF7+ahWpl7YHbo4ygWqAl3eowfm 46cZi48/sEl8Bxv3IpTlUkU75fzasnDqvimKl3pajwGqyriJIMpyXWyUSUjQJaqk1Xze cJmHdGH2Kwb+lmtZ45yaxvSZMyrd8OivvxMm5idQRwDrVumhIZYwNmhzobQxGldTSca0 IeJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ofKTU8s93Yu2rM/fmGaOrrNeXKEZaodPNsHLyk7YFKc=; b=FLQrgJX21VQCmZijLDhUpybcRZNFA1PoIUu1ha0uZeydEWtkjaR4lTcItHiZNwNSs7 ZDWuZm+RH10qbOb4hiHs76NZHz/bECiMBCNq3HBG7IUK81riqIemD1oAMXdmtM4Vwkia YjOVmmq73Ziiv7Zc6Fm7++5yvndu8PtWByxm/8Q/dF7fezNCfm71VXS7YYL5BqkgQNcu I/PxIkU9ccIT+o9m+92qS61QI/YnBFAbT3LyhpgejJC+m2BnElsHb7uGFj0aEh1QiwAQ xkAY0lGTC/R0AT3GysidSmlQSVhBdt1BmYB1rN8WyaphCwBWcz+BWpxUrh5wDcRgQ5uZ 1TZQ== X-Gm-Message-State: AOAM530uSFYDcNujtPfm4S0rJpEqeaQ8iWl6bzYMpzorwZlsO2TffqIa CkCelHzopr7gEYLKx9+WEDaOjw== X-Google-Smtp-Source: ABdhPJyu8MOKaGOM4pcmWlx5aDi5lhHtms/5L7yJ6jZ8ns80O/XzxBRa6aCQ8cGCi4Jt6TalL/Sxqg== X-Received: by 2002:a9d:1a6:: with SMTP id e35mr19589299ote.238.1606020279605; Sat, 21 Nov 2020 20:44:39 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id t5sm4382777oth.16.2020.11.21.20.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Nov 2020 20:44:38 -0800 (PST) Date: Sat, 21 Nov 2020 22:44:34 -0600 From: Bjorn Andersson To: "N?colas F. R. A. Prado" Cc: Pavel Machek , Dan Murphy , Andy Gross , Rob Herring , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Brian Masney , Luca Weiss , Russell King , Georgi Djakov , linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org, andrealmeid@collabora.com Subject: Re: [RFC PATCH 1/3] leds: Add driver for QPNP flash led Message-ID: <20201122044434.GG95182@builder.lan> References: <20201106165737.1029106-1-nfraprado@protonmail.com> <20201106165737.1029106-2-nfraprado@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201106165737.1029106-2-nfraprado@protonmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 06 Nov 10:58 CST 2020, N?colas F. R. A. Prado wrote: > Add driver for the QPNP flash LED. It works over SPMI and is part of the > PM8941 PMIC. > > Signed-off-by: Nícolas F. R. A. Prado > --- > drivers/leds/Kconfig | 9 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-qpnp.c | 1351 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 1361 insertions(+) > create mode 100644 drivers/leds/leds-qpnp.c > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index 849d3c5f908e..ca5f6e81c064 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -928,6 +928,15 @@ config LEDS_ACER_A500 > This option enables support for the Power Button LED of > Acer Iconia Tab A500. > > +config LEDS_QPNP > + tristate "Support for QPNP LEDs" > + depends on SPMI > + help > + This driver supports the flash/torch led of Qualcomm PNP PMIC. > + > + To compile this driver as a module, choose M here: the module will > + be called leds-qpnp. > + Downstream they seem to have a single "led driver" dealing with all the LED related interfaces in the PMIC. We have WLED upstream already and I've been poking at an "LPG" driver. So as you look into Jacek's request please make this a "qcom spmi flash driver", instead of a "qpnp leds" driver. Regards, Bjorn