From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA1BC56202 for ; Sun, 22 Nov 2020 11:42:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0C90208D5 for ; Sun, 22 Nov 2020 11:42:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727735AbgKVLmZ (ORCPT ); Sun, 22 Nov 2020 06:42:25 -0500 Received: from correo.us.es ([193.147.175.20]:33208 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727621AbgKVLmY (ORCPT ); Sun, 22 Nov 2020 06:42:24 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 8D5EA53D26C for ; Sun, 22 Nov 2020 12:42:22 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 7E76FDA72F for ; Sun, 22 Nov 2020 12:42:22 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 6AE3CDA852; Sun, 22 Nov 2020 12:42:22 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 36DC1DA704; Sun, 22 Nov 2020 12:42:20 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Sun, 22 Nov 2020 12:42:20 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 1549141FF201; Sun, 22 Nov 2020 12:42:20 +0100 (CET) Date: Sun, 22 Nov 2020 12:42:19 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Alexander Lobakin Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org, fw@strlen.de, razor@blackwall.org, jeremy@azazel.net, tobias@waldekranz.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next,v5 0/9] netfilter: flowtable bridge and vlan enhancements Message-ID: <20201122114219.GA27397@salvia> References: <20201122102605.2342-1-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201122102605.2342-1-alobakin@pm.me> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 22, 2020 at 10:26:16AM +0000, Alexander Lobakin wrote: > From: Pablo Neira Ayuso > Date: Fri, 20 Nov 2020 13:49:12 +0100 [...] > > Something like this: > > > > fast path > > .------------------------. > > / \ > > | IP forwarding | > > | / \ . > > | br0 eth0 > > . / \ > > -- veth1 veth2 > > . > > . > > . > > eth0 > > ab:cd:ef:ab:cd:ef > > VM > > I'm concerned about bypassing vlan and bridge's .ndo_start_xmit() in > case of this shortcut. We'll have incomplete netdevice Tx stats for > these two, as it gets updated inside this callbacks. TX device stats are being updated accordingly. # ip netns exec nsr1 ip -s link 1: lo: mtu 65536 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 RX: bytes packets errors dropped overrun mcast 0 0 0 0 0 0 TX: bytes packets errors dropped carrier collsns 0 0 0 0 0 0 2: veth0@if2: mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000 link/ether 82:0d:f3:b5:59:5d brd ff:ff:ff:ff:ff:ff link-netns ns1 RX: bytes packets errors dropped overrun mcast 213290848248 4869765 0 0 0 0 TX: bytes packets errors dropped carrier collsns 315346667 4777953 0 0 0 0 3: veth1@if2: mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000 link/ether 4a:81:2d:9a:02:88 brd ff:ff:ff:ff:ff:ff link-netns ns2 RX: bytes packets errors dropped overrun mcast 315337919 4777833 0 0 0 0 TX: bytes packets errors dropped carrier collsns 213290844826 4869708 0 0 0 0 4: br0: mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000 link/ether 82:0d:f3:b5:59:5d brd ff:ff:ff:ff:ff:ff RX: bytes packets errors dropped overrun mcast 4101 73 0 0 0 0 TX: bytes packets errors dropped carrier collsns 5256 74 0 0 0 0 5: veth0.10@veth0: mtu 1500 qdisc noqueue master br0 state UP mode DEFAULT group default qlen 1000 link/ether 82:0d:f3:b5:59:5d brd ff:ff:ff:ff:ff:ff RX: bytes packets errors dropped overrun mcast 4101 73 0 0 0 62 TX: bytes packets errors dropped carrier collsns 315342363 4777893 0 0 0 0