From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55046C56202 for ; Mon, 23 Nov 2020 13:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7D4B20729 for ; Mon, 23 Nov 2020 13:41:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730100AbgKWNl1 (ORCPT ); Mon, 23 Nov 2020 08:41:27 -0500 Received: from mga18.intel.com ([134.134.136.126]:48041 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730017AbgKWNl0 (ORCPT ); Mon, 23 Nov 2020 08:41:26 -0500 IronPort-SDR: E6ay4+tGUJVinhptYiSodE4mAMA0vKGqbojYzI85WedfTSF+/TYpTOguHKZgzrK+fcG8twzZ76 ATSx+OC2jhYg== X-IronPort-AV: E=McAfee;i="6000,8403,9813"; a="159530411" X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="159530411" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 05:41:26 -0800 IronPort-SDR: 54UAbvcIFwMBqmRQiln1zfuPud/opx+vgQoVASq3noCQFKIqxM80S+39jFwGrptkf5MMtMXMlA oKnGJDLfAXsA== X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="432292518" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 05:41:23 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1khC6r-009ASD-HD; Mon, 23 Nov 2020 15:42:25 +0200 Date: Mon, 23 Nov 2020 15:42:25 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Mark Brown , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Liam Girdwood , alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Shengjiu Wang Subject: Re: [PATCH 01/38] ASoC: ak5558: drop of_match_ptr from of_device_id table Message-ID: <20201123134225.GF4077@smile.fi.intel.com> References: <20201120161653.445521-1-krzk@kernel.org> <20201120165202.GG6751@sirena.org.uk> <20201120194245.GA2925@kozik-lap> <20201120200429.GJ6751@sirena.org.uk> <20201122105813.GA3780@kozik-lap> <20201123104832.GY4077@smile.fi.intel.com> <20201123123731.GA6322@sirena.org.uk> <20201123124129.GA170000@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201123124129.GA170000@kozik-lap> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 23, 2020 at 01:41:29PM +0100, Krzysztof Kozlowski wrote: > On Mon, Nov 23, 2020 at 12:37:31PM +0000, Mark Brown wrote: > > On Mon, Nov 23, 2020 at 12:48:32PM +0200, Andy Shevchenko wrote: > > > On Sun, Nov 22, 2020 at 11:59:20AM +0100, Krzysztof Kozlowski wrote: > > > > On Fri, Nov 20, 2020 at 08:04:29PM +0000, Mark Brown wrote: > > > > > > > Surely if that's the desired outcome the fix is to change the definition > > > > > of of_match_ptr() such that it leaves the reference with CONFIG_ACPI, > > > > > perhaps hidden behind a config option for PRP0001? That seems better > > > > > than going through the entire tree like this. > > > > > > That could be indeed an easier way to achieve this. > > > > > ...easier and wrong in my opinion. Not all drivers need that. > > > What the point to touch it in the driver which is OF-only? > > > (For IP which will quite unlikely to be present in ACPI world) > > > Or if the device will get the correct ACPI ID? > > > > That feels like something that should be done with Kconfig dependencies > > like a direct OF dependency (possibly a !PRP0001 dependency?) for the > > driver or possibly with having a variant of_match_ptr() for things that > > really don't want to support PRP0001. Just removing all the use of > > of_match_ptr() is both noisy and confusing in that it looks like it's > > creating issues to fix, it makes it hard to understand when and why one > > should use the macro. > > For the OF-only drivers (without other ID table), there is no point to > use the macro. Driver can bind only with DT, so what is the point of > of_match_ptr? To skip the OF table when building without OF? Driver > won't be usable at all in such case. So maybe for compile testing? > There is no need to remove OF table for simple build tests. I'm on the same page here. -- With Best Regards, Andy Shevchenko