Re: [PATCH 01/38] ASoC: ak5558: drop of_match_ptr from of_device_id table

Mark Brown
2020-11-20T20:04:53Z

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On Fri, Nov 20, 2020 at 08:42:45PM +0100, Krzysztof Kozlowski wrote:
> On Fri, Nov 20, 2020 at 04:56:34PM +0000, Mark Brown wrote:

> > It would be better to fix these by annotating the table as potentially
> > unused, if nothing else it means if someone wants to add ACPI support
> > (or it just works on their ACPI system with the plain old I2C ID) then
> > they don't need to revert this change.

> The point is after this patch - removal of of_match_ptr() - they will
> already support the ACPI matching through the PRP0001.

> Keeping of_match_ptr() and maybe_unused will prevent any ACPI re-usage
> unless explicit ACPI table is added

Surely if that's the desired outcome the fix is to change the definition
of of_match_ptr() such that it leaves the reference with CONFIG_ACPI,
perhaps hidden behind a config option for PRP0001? That seems better
than going through the entire tree like this.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]