From: Jason Gunthorpe <jgg@nvidia.com>
To: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Cc: <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] IB/mthca: fix return value of error branch in mthca_init_cq()
Date: Mon, 23 Nov 2020 16:28:09 -0400 [thread overview]
Message-ID: <20201123202809.GA44105@nvidia.com> (raw)
In-Reply-To: <1605837422-42724-1-git-send-email-wangxiongfeng2@huawei.com>
On Fri, Nov 20, 2020 at 09:57:02AM +0800, Xiongfeng Wang wrote:
> We return 'err' in the error branch, but this variable may be set as
> zero by the above code. Fix it by setting 'err' as a negative value
> before we goto the error label.
>
> Fixes: 74c2174e7be5 ("IB uverbs: add mthca user CQ support")
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> ---
> drivers/infiniband/hw/mthca/mthca_cq.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2020-11-23 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 1:57 [PATCH v2] IB/mthca: fix return value of error branch in mthca_init_cq() Xiongfeng Wang
2020-11-23 20:28 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123202809.GA44105@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox