From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: "Ye, Xiang" <xiang.ye@intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>, <jikos@kernel.org>,
<srinivas.pandruvada@linux.intel.com>,
<linux-input@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] iio: hid-sensors: Add hinge sensor driver
Date: Tue, 24 Nov 2020 11:39:51 +0000 [thread overview]
Message-ID: <20201124113951.000009ea@Huawei.com> (raw)
In-Reply-To: <20201124064332.GA21403@host>
> >
> > > +
> > > + To compile this driver as a module, choose M here: the
> > > + module will be called hid-sensor-custom-hinge.
> > > +
> > > endmenu
> > > diff --git a/drivers/iio/position/Makefile b/drivers/iio/position/Makefile
> > > index 3cbe7a734352..7a6225977a01 100644
> > > --- a/drivers/iio/position/Makefile
> > > +++ b/drivers/iio/position/Makefile
> > > @@ -5,3 +5,6 @@
> > > # When adding new entries keep the list in alphabetical order
> > >
> > > obj-$(CONFIG_IQS624_POS) += iqs624-pos.o
> > > +
> > > +obj-$(CONFIG_HID_SENSOR_CUSTOM_HINGE) += hid-sensor-custom-hinge.o
> >
> > Alphabetical order preferred.
> >
> > > +ccflags-y += -I$(srctree)/drivers/iio/common/hid-sensors
> >
> > Why?
> hinge driver need to include #include "hid-sensor-trigger.h", if not using this cflag-y
> it should be #include "../common/hid-sensors/hid-sensor-trigger.h"
Even though that looks a bit ugly, I'd prefer that rather than having to realize we
were doing something not entirely obvious in the Makefile.
Thanks,
Jonathan
next prev parent reply other threads:[~2020-11-24 11:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 10:03 [PATCH v2 0/4] add custom hinge sensor support Ye Xiang
2020-11-19 10:03 ` [PATCH v2 1/4] HID: hid-sensor-custom: Add custom sensor iio support Ye Xiang
2020-11-21 17:21 ` Jonathan Cameron
2020-11-24 10:29 ` Ye, Xiang
2020-11-24 11:32 ` Jonathan Cameron
2020-11-25 2:27 ` Ye, Xiang
2020-11-28 13:29 ` Jonathan Cameron
2020-11-19 10:03 ` [PATCH v2 2/4] iio: hid-sensor-trigger: Decrement runtime pm enable count on driver removal Ye Xiang
2020-11-21 17:22 ` Jonathan Cameron
2020-11-22 1:54 ` Pandruvada, Srinivas
2020-11-19 10:03 ` [PATCH v2 3/4] iio: hid-sensor-trigger: Use iio->trig instead trig field internal structure Ye Xiang
2020-11-21 17:33 ` Jonathan Cameron
2020-11-19 10:03 ` [PATCH v2 4/4] iio: hid-sensors: Add hinge sensor driver Ye Xiang
2020-11-21 17:56 ` Jonathan Cameron
2020-11-22 1:46 ` Pandruvada, Srinivas
2020-11-22 2:14 ` Pandruvada, Srinivas
2020-11-22 14:14 ` Jonathan Cameron
2020-11-22 15:51 ` Pandruvada, Srinivas
2020-11-22 16:50 ` Jonathan Cameron
2020-11-24 3:30 ` Ye, Xiang
2020-11-24 11:36 ` Jonathan Cameron
2020-11-25 3:24 ` Ye, Xiang
2020-11-24 6:43 ` Ye, Xiang
2020-11-24 11:39 ` Jonathan Cameron [this message]
2020-11-25 2:39 ` Ye, Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124113951.000009ea@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=xiang.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox