From: Christoph Hellwig <hch@lst.de>
To: Jianxiong Gao <jxgao@google.com>
Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me,
m.szyprowski@samsung.com, robin.murphy@arm.com,
konrad.wilk@oracle.com, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] [PATCH] Adding offset keeping option when mapping data via SWIOTLB.
Date: Tue, 24 Nov 2020 12:49:06 +0100 [thread overview]
Message-ID: <20201124114906.GA22619@lst.de> (raw)
In-Reply-To: <20201123221807.3344263-1-jxgao@google.com>
On Mon, Nov 23, 2020 at 02:18:07PM -0800, Jianxiong Gao wrote:
> NVMe driver and other applications may depend on the data offset
> to operate correctly. Currently when unaligned data is mapped via
> SWIOTLB, the data is mapped as slab aligned with the SWIOTLB. When
> booting with --swiotlb=force option and using NVMe as interface,
> running mkfs.xfs on Rhel fails because of the unalignment issue.
> This patch adds an option to make sure the mapped data preserves
> its offset of the orginal addrss. Tested on latest kernel that
> this patch fixes the issue.
>
> Signed-off-by: Jianxiong Gao <jxgao@google.com>
> Acked-by: David Rientjes <rientjes@google.com>
I think we actually need to do this by default. There are plenty
of other hardware designs that rely on dma mapping not adding
offsets that did not exist, e.g. ahci and various RDMA NICs.
next prev parent reply other threads:[~2020-11-24 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 22:18 [PATCH] [PATCH] Adding offset keeping option when mapping data via SWIOTLB Jianxiong Gao
2020-11-24 11:49 ` Christoph Hellwig [this message]
2020-11-24 21:46 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124114906.GA22619@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jxgao@google.com \
--cc=kbusch@kernel.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox