From: Christoph Hellwig <hch@lst.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v2 2/2] uuid: Make guid_t completely internal type to the kernel
Date: Tue, 24 Nov 2020 14:39:45 +0100 [thread overview]
Message-ID: <20201124133945.GA30840@lst.de> (raw)
In-Reply-To: <20201030184950.26732-2-andriy.shevchenko@linux.intel.com>
On Fri, Oct 30, 2020 at 08:49:50PM +0200, Andy Shevchenko wrote:
> diff --git a/include/uapi/linux/uuid.h b/include/uapi/linux/uuid.h
> index e5a7eecef7c3..c3e175f686f4 100644
> --- a/include/uapi/linux/uuid.h
> +++ b/include/uapi/linux/uuid.h
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> /*
> - * UUID/GUID definition
> + * MEI UUID definition
> *
> * Copyright (C) 2010, Intel Corp.
> * Huang Ying <ying.huang@intel.com>
> @@ -22,21 +22,17 @@
>
> typedef struct {
> __u8 b[16];
> -} guid_t;
> +} uuid_le;
IMHO we should kill this header entirely and move the definition to
<uapi/linux/mei.h> under a new name so that no one picks up the
definition by accident.
next prev parent reply other threads:[~2020-11-24 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 18:49 [PATCH v2 1/2] modpost: Mark uuid_le type only for MEI Andy Shevchenko
2020-10-30 18:49 ` [PATCH v2 2/2] uuid: Make guid_t completely internal type to the kernel Andy Shevchenko
2020-11-16 11:40 ` Andy Shevchenko
2020-11-24 13:39 ` Christoph Hellwig [this message]
2020-11-24 14:07 ` Andy Shevchenko
2020-11-24 14:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124133945.GA30840@lst.de \
--to=hch@lst.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox