From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A0ADC2D0E4 for ; Tue, 24 Nov 2020 22:15:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACC6C20866 for ; Tue, 24 Nov 2020 22:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389302AbgKXWPU (ORCPT ); Tue, 24 Nov 2020 17:15:20 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:48340 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389230AbgKXWPT (ORCPT ); Tue, 24 Nov 2020 17:15:19 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1khgaT-008guk-Bs; Tue, 24 Nov 2020 23:15:01 +0100 Date: Tue, 24 Nov 2020 23:15:01 +0100 From: Andrew Lunn To: Chris Packham Cc: Aryan Srivastava , "robh+dt@kernel.org" , "gregory.clement@bootlin.com" , "sebastian.hesselbarth@gmail.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] ARM: dts: mvebu: Add device tree for RD-AC3X-48G4X2XL board Message-ID: <20201124221501.GI2036992@lunn.ch> References: <20201123035215.2239-1-aryan.srivastava@alliedtelesis.co.nz> <95016967-257b-e715-c907-0ac396e125ee@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <95016967-257b-e715-c907-0ac396e125ee@alliedtelesis.co.nz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +&i2c0 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c0_pins>; > > + status = "okay"; > > + > > + eeprom@53{ > > + compatible = "atmel,24c64"; > > + reg = <0x53>; > > + }; > > +// cpld@3c{ > > +// compatible = "marvell,ac3x-cpld"; > > +// reg = <0x3c>; > > +// }; > > +}; > > Question for the mvebu maintainers: We know there is a cpld with that > can be interfaced with over i2c. Other than detecting that it shows up > on the i2c bus we haven't done anything with it. We believe it > interfaces with some discrete IO and might mux the i2c interface towards > the SFP/QSFP cages. > > Obviously there isn't a "marvell,ac3x-cpld" driver (yet) so I suggested > to Aryan that we put it in the dts to document its existence but leave > it commented out for now. Is this OK? Hi Chris I would just add a text comment, not DT. We have no idea what this node will look like until we have the driver. Is there an open source 'vendor crap driver'? Do we have anything to go on? Andrew