From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E5AC56202 for ; Thu, 26 Nov 2020 04:26:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B620121973 for ; Thu, 26 Nov 2020 04:26:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fLtI8KH5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387676AbgKZE0v (ORCPT ); Wed, 25 Nov 2020 23:26:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:57206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730980AbgKZE0v (ORCPT ); Wed, 25 Nov 2020 23:26:51 -0500 Received: from localhost (unknown [122.179.79.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C51521741; Thu, 26 Nov 2020 04:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606364811; bh=9Ab23uvA6gXoRUJ95dH3UVCAG+CifoKA/aDKNyM0a8A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fLtI8KH5wUOVTxE+nyeGSuezEqsK9cAE8jeOLXlbIz2kEvhFGmE/9CSTPV059Kh9E vJB0YPH/jG+5eOGo8oa6nwmq+pkzRp13wRnULW4s46O7X0NKgIBWUdsJ5osuvf4Ekt FWEaez9fYQuTMifCzBS7flTgh7GbkYad1jMg4bys= Date: Thu, 26 Nov 2020 09:56:46 +0530 From: Vinod Koul To: Randy Dunlap Cc: Srinivas Kandagatla , kernel test robot , Jonathan Marek , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Bard Liao , moderated for non-subscribers , Pierre-Louis Bossart Subject: Re: drivers/soundwire/qcom.c:767: undefined reference to `slimbus_bus' Message-ID: <20201126042646.GH8403@vkoul-mobl> References: <202011030351.iq9CBMO3-lkp@intel.com> <20201125055155.GD8403@vkoul-mobl> <6e298ed8-dc23-7a1f-1bb1-44ba2f43ee07@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e298ed8-dc23-7a1f-1bb1-44ba2f43ee07@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25-11-20, 09:31, Randy Dunlap wrote: > On 11/24/20 9:51 PM, Vinod Koul wrote: > > From: Vinod Koul > > Date: Wed, 25 Nov 2020 11:15:22 +0530 > > Subject: [PATCH] soundwire: qcom: Fix build failure when slimbus is module > > > > Commit 5bd773242f75 ("soundwire: qcom: avoid dependency on > > CONFIG_SLIMBUS") removed hard dependency on Slimbus for qcom driver but > > it results in build failure when: > > CONFIG_SOUNDWIRE_QCOM=y > > CONFIG_SLIMBUS=m > > > > drivers/soundwire/qcom.o: In function `qcom_swrm_probe': > > qcom.c:(.text+0xf44): undefined reference to `slimbus_bus' > > > > Fix this by using IS_REACHABLE() in driver which is recommended to be > > sued with imply. > > used right > > > > > Fixes: 5bd773242f75 ("soundwire: qcom: avoid dependency on CONFIG_SLIMBUS") > > Reported-by: kernel test robot > > Signed-off-by: Vinod Koul > > Acked-by: Randy Dunlap # build-tested Thanks I have added this and Srini's and pushed out now. -- ~Vinod