From: Vinod Koul <vkoul@kernel.org>
To: "Reddy, MallikarjunaX" <mallikarjunax.reddy@linux.intel.com>
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
andriy.shevchenko@intel.com, chuanhua.lei@linux.intel.com,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
malliamireddy009@gmail.com, peter.ujfalusi@ti.com
Subject: Re: [PATCH v9 2/2] Add Intel LGM SoC DMA support.
Date: Thu, 26 Nov 2020 10:20:35 +0530 [thread overview]
Message-ID: <20201126045035.GI8403@vkoul-mobl> (raw)
In-Reply-To: <ee275d37-5dda-205a-a897-7a61ad13b536@linux.intel.com>
On 25-11-20, 18:39, Reddy, MallikarjunaX wrote:
> > > > > desc needs to be configure for each dma channel and the remapped address of
> > > > > the IGP & EGP is desc base adress.
> > > > Why should this address not passed as src_addr/dst_addr?
> > > src_addr/dst_addr is the data pointer. Data pointer indicates address
> > > pointer of data buffer.
> > >
> > > ldma_chan_desc_cfg() carries the descriptor address.
> > >
> > > The descriptor list entry contains the data pointer, which points to the
> > > data section in the memory.
> > >
> > > So we should not use src_addr/dst_addr as desc base address.
> > Okay sounds reasonable. why is this using in API here?
> descriptor base address needs to be write into the dma register (DMA_CDBA).
Why cant descriptor be allocated by damenegine driver, passed to client
as we normally do in prep_* callbacks ? Why do you need a custom API
--
~Vinod
next prev parent reply other threads:[~2020-11-26 4:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 5:38 [PATCH v9 0/2] Add Intel LGM SoC DMA support Amireddy Mallikarjuna reddy
2020-11-12 5:38 ` [PATCH v9 1/2] dt-bindings: dma: Add bindings for Intel LGM SoC Amireddy Mallikarjuna reddy
2020-11-16 19:19 ` Rob Herring
2020-11-18 15:55 ` Vinod Koul
2020-11-20 11:30 ` Reddy, MallikarjunaX
2020-11-21 12:19 ` Vinod Koul
2020-11-23 16:30 ` Reddy, MallikarjunaX
2020-11-24 17:23 ` Vinod Koul
2020-11-25 10:39 ` Reddy, MallikarjunaX
2020-11-12 5:38 ` [PATCH v9 2/2] Add Intel LGM SoC DMA support Amireddy Mallikarjuna reddy
2020-11-18 17:38 ` Vinod Koul
2020-11-20 11:30 ` Reddy, MallikarjunaX
2020-11-21 12:17 ` Vinod Koul
2020-11-23 16:29 ` Reddy, MallikarjunaX
2020-11-24 17:21 ` Vinod Koul
2020-11-25 10:39 ` Reddy, MallikarjunaX
2020-11-26 4:50 ` Vinod Koul [this message]
2020-11-30 6:20 ` Reddy, MallikarjunaX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126045035.GI8403@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=chuanhua.lei@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malliamireddy009@gmail.com \
--cc=mallikarjunax.reddy@linux.intel.com \
--cc=peter.ujfalusi@ti.com \
--cc=qi-ming.wu@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox