From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B4C2C83A99 for ; Sat, 28 Nov 2020 22:23:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B34A2231B for ; Sat, 28 Nov 2020 22:23:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UzBGcVRF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730144AbgK1VtX (ORCPT ); Sat, 28 Nov 2020 16:49:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38026 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727455AbgK0Tp7 (ORCPT ); Fri, 27 Nov 2020 14:45:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606506349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5gA9oQYSyBT4Z0vJhRDeAJKF5kHu/LWhQyfFb1ooOvQ=; b=UzBGcVRF/atUJ5X3W1838AP1FQTJfw1+BMYQDY/1ngYHdndq92Ryz6B/gYEndA0g0+Bfmu fDyHuz6zpoXv/PW5NqNuSCAuUWTpfv/BpGPf1qLRTszqiSXqUFYgsIILuZ3ZjJXdARrafv 4gKvwSJOF5hrCX6TiFbaE0H5+NtlgKQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-5Rvl11ApMEKCsSqgButfqw-1; Fri, 27 Nov 2020 14:45:45 -0500 X-MC-Unique: 5Rvl11ApMEKCsSqgButfqw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 349E01005D50; Fri, 27 Nov 2020 19:45:43 +0000 (UTC) Received: from krava (unknown [10.40.194.2]) by smtp.corp.redhat.com (Postfix) with SMTP id EE7DB60BD9; Fri, 27 Nov 2020 19:45:39 +0000 (UTC) Date: Fri, 27 Nov 2020 20:45:39 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Namhyung Kim , Alexander Shishkin , Michael Petlan , Song Liu , Ian Rogers , Stephane Eranian , Alexey Budankov , Andi Kleen , Adrian Hunter Subject: Re: [PATCH 09/25] perf tools: Add support to read build id from compressed elf Message-ID: <20201127194539.GA2788968@krava> References: <20201126170026.2619053-1-jolsa@kernel.org> <20201126170026.2619053-10-jolsa@kernel.org> <20201126174620.GA70905@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126174620.GA70905@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2020 at 02:46:20PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 26, 2020 at 06:00:10PM +0100, Jiri Olsa escreveu: > > Adding support to decompress file before reading build id. > > > > Adding filename__read_build_id and change its current > > versions to read_build_id. > > > > Shutting down stderr output of perf list in the shell test: > > 82: Check open filename arg using perf trace + vfs_getname : Ok > > > > because with decompression code in the place we the > > filename__read_build_id function is more verbose in case > > of error and the test did not account for that. > > There are two patches here, right? Also the test output shows it after, > before is missing, showing what the test wasn't accounting for. hum, I'm not sure I understand, the test fails because the change introduced more terminal output, so I think it needs to be together > > - Arnaldo > > > Signed-off-by: Jiri Olsa > > --- > > .../tests/shell/trace+probe_vfs_getname.sh | 2 +- > > tools/perf/util/symbol-elf.c | 37 ++++++++++++++++++- > > 2 files changed, 36 insertions(+), 3 deletions(-) > > > > diff --git a/tools/perf/tests/shell/trace+probe_vfs_getname.sh b/tools/perf/tests/shell/trace+probe_vfs_getname.sh > > index 11cc2af13f2b..3660fcc02fef 100755 > > --- a/tools/perf/tests/shell/trace+probe_vfs_getname.sh > > +++ b/tools/perf/tests/shell/trace+probe_vfs_getname.sh > > @@ -20,7 +20,7 @@ skip_if_no_perf_trace || exit 2 > > file=$(mktemp /tmp/temporary_file.XXXXX) > > > > trace_open_vfs_getname() { > > - evts=$(echo $(perf list syscalls:sys_enter_open* 2>&1 | egrep 'open(at)? ' | sed -r 's/.*sys_enter_([a-z]+) +\[.*$/\1/') | sed 's/ /,/') > > + evts=$(echo $(perf list syscalls:sys_enter_open* >&1 2>/dev/nul | egrep 'open(at)? ' | sed -r 's/.*sys_enter_([a-z]+) +\[.*$/\1/') | sed 's/ /,/') and one extra 'l' missing in /dev/nul ;-) also perhaps the >&1 is superfluous jirka