From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF0EC3E8C5 for ; Sun, 29 Nov 2020 08:28:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEA622076C for ; Sun, 29 Nov 2020 08:28:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uXw98Nlw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgK2I2Z (ORCPT ); Sun, 29 Nov 2020 03:28:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725839AbgK2I2Z (ORCPT ); Sun, 29 Nov 2020 03:28:25 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE9B5C0613D1 for ; Sun, 29 Nov 2020 00:27:44 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id z7so10910927wrn.3 for ; Sun, 29 Nov 2020 00:27:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Mwp+wLhKN7vN1/marM/K/cNTZgEqNTEdBKewJkpgExE=; b=uXw98NlwdRQWqRkNdQa2fd99jOkOsRq2nFbhIblejp+1K8VLWcydvxpPAl0WtpEkEz 5Ujj/MqrlI3dxocx8hemaLqKOqx09IE8Ji+LVzBD1PpGLQ6EH93gH2ECGUxhFZsQTByk 6tKVPIUKuyE5MyHdrK4DQi8AIURUGlhyz2VTIRAoyk2LaHx6Q9+xMYCsjTeEC5kuHSMU f6mxRQLirf+bAspbt6ydgkKzwSCyaKNOuMBwrF1TDvv2AGI3+ZOhqfGdVEVeAY7nBEaB i+UwDR3r+e2qiYtuxaZ4Y0sE3TQ5+1Hthjh9Y6913piK+zUxhrfTVjNN6/A7PYpVR8xX MrkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Mwp+wLhKN7vN1/marM/K/cNTZgEqNTEdBKewJkpgExE=; b=iQNvIY9f6kS3vnujw88u+h906aNKkgSwIeNg3TtXWo2hJZR8x2hwoM4fmcQvFOs1qz cjx8JIx1ICj79pvxvGFB1LYDkmoVH0iwBOkaDQRg05gDYJTeMv2AB0xoF6p55HSrJ4zx ARYgov1L6FFZlB6KcezQSHF0PaL6toHS4PDC8Yo8Xj6v9i4ewf1JtAoxiYvaVXrXhdxk zg9m+bHbzDpg7sLe7hkQ3JIBBLloVslmHpWVOC34jI+vlwzxLODgDlDW1cZluPtz9i0H hE5hcoynYoiYmyCXWH8xYe90ZH9BaIObLZXY60rjnfP3SeFBFA4Gr57URVTtdurA21dg M11w== X-Gm-Message-State: AOAM533Aq3SIGOmOjuAzwSWdSXsQBsspjiy4EsbylUJkDoRJJxABvgoj HXtzFSzd+WD0N7MfQqizHmWg4Q== X-Google-Smtp-Source: ABdhPJwS5LRuWrn3ndaQ29NyblSdbZ8UHSMefZd4iI1cwaQF2OzW0V7m+sO9yafUKvk3LX2kcphHwg== X-Received: by 2002:a5d:538a:: with SMTP id d10mr21784381wrv.368.1606638463179; Sun, 29 Nov 2020 00:27:43 -0800 (PST) Received: from dell ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id l14sm19760636wmi.33.2020.11.29.00.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Nov 2020 00:27:42 -0800 (PST) Date: Sun, 29 Nov 2020 08:27:40 +0000 From: Lee Jones To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, Henrik Rydberg , James Hilliard , Daniel Ritz , linux-input@vger.kernel.org Subject: Re: [PATCH v2 3/4] input: touchscreen: usbtouchscreen: Remove unused variable 'ret' Message-ID: <20201129082740.GB3857718@dell> References: <20201126133607.3212484-1-lee.jones@linaro.org> <20201126133607.3212484-4-lee.jones@linaro.org> <20201129025959.GJ2034289@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201129025959.GJ2034289@dtor-ws> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 28 Nov 2020, Dmitry Torokhov wrote: > Hi Lee, > > On Thu, Nov 26, 2020 at 01:36:06PM +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’: > > drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > > > > Cc: Dmitry Torokhov > > Cc: Henrik Rydberg > > Cc: James Hilliard > > Cc: Daniel Ritz > > Cc: linux-input@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > drivers/input/touchscreen/usbtouchscreen.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c > > index 397cb1d3f481b..c3b7130cd9033 100644 > > --- a/drivers/input/touchscreen/usbtouchscreen.c > > +++ b/drivers/input/touchscreen/usbtouchscreen.c > > @@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) > > unsigned int data_len = be16_to_cpu(packet->data_len); > > unsigned int x_len = be16_to_cpu(packet->x_len); > > unsigned int y_len = be16_to_cpu(packet->y_len); > > - int x, y, begin_x, begin_y, end_x, end_y, w, h, ret; > > + int x, y, begin_x, begin_y, end_x, end_y, w, h; > > > > /* got touch data? */ > > if ((pkt[0] & 0xe0) != 0xe0) > > @@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) > > x_len -= 0x80; > > > > /* send ACK */ > > - ret = usb_submit_urb(priv->ack, GFP_ATOMIC); > > + usb_submit_urb(priv->ack, GFP_ATOMIC); > > I thought you were going to add error handling here? Hmm... I thought I handed all of the review comments! Will look into this again on Monday. > > if (!usbtouch->type->max_xc) { > > usbtouch->type->max_xc = 2 * x_len; > > Thanks. > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog