From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18740C5519F for ; Mon, 30 Nov 2020 09:14:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8C042076E for ; Mon, 30 Nov 2020 09:14:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="fmsIyXHi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728030AbgK3JOD (ORCPT ); Mon, 30 Nov 2020 04:14:03 -0500 Received: from z5.mailgun.us ([104.130.96.5]:57656 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727809AbgK3JOC (ORCPT ); Mon, 30 Nov 2020 04:14:02 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1606727625; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=SdkfUaGEnsQaKGcSRPesjSEXe34DQXrgiTsCu4nbNRc=; b=fmsIyXHiFXi+t050kf/q1hNjidGbmLqubKt1TdW8TEqcuxJphO/ZMKaBJuvi9Bw9RMS9mRcb c4AwNg+AI7MAkoQy26uAfWfnnay2VioS3DJyabghHVXIqWNIbbcxJBWwBWMMS2hzRa4HTlKt 5fYOyl7JKHSGAH5sTJre4UkQY0o= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 5fc4b7a222377520ee49e426 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 30 Nov 2020 09:13:06 GMT Sender: jackp=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 2ADE1C43462; Mon, 30 Nov 2020 09:13:06 +0000 (UTC) Received: from jackp-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jackp) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7C6D5C433ED; Mon, 30 Nov 2020 09:13:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7C6D5C433ED Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=jackp@codeaurora.org Date: Mon, 30 Nov 2020 01:13:00 -0800 From: Jack Pham To: Greg Kroah-Hartman Cc: balbi@kernel.org, peter.chen@nxp.com, willmcvicker@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "taehyun.cho" , stable Subject: Re: [PATCH v2 4/5] USB: gadget: f_fs: add SuperSpeed Plus support Message-ID: <20201130091259.GB31406@jackp-linux.qualcomm.com> References: <20201127140559.381351-1-gregkh@linuxfoundation.org> <20201127140559.381351-5-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201127140559.381351-5-gregkh@linuxfoundation.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 27, 2020 at 03:05:58PM +0100, Greg Kroah-Hartman wrote: > From: "taehyun.cho" > > Setup the descriptors for SuperSpeed Plus for f_fs. This allows the > gadget to work properly without crashing at SuperSpeed rates. > > Cc: Felipe Balbi > Cc: stable > Signed-off-by: taehyun.cho > Signed-off-by: Will McVicker > Reviewed-by: Peter Chen > Signed-off-by: Greg Kroah-Hartman > --- > drivers/usb/gadget/function/f_fs.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index 046f770a76da..a34a7c96a1ab 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -1327,6 +1327,7 @@ static long ffs_epfile_ioctl(struct file *file, unsigned code, > struct usb_endpoint_descriptor *desc; > > switch (epfile->ffs->gadget->speed) { > + case USB_SPEED_SUPER_PLUS: > case USB_SPEED_SUPER: > desc_idx = 2; > break; > @@ -3222,6 +3223,10 @@ static int _ffs_func_bind(struct usb_configuration *c, > func->function.os_desc_n = > c->cdev->use_os_string ? ffs->interfaces_count : 0; > > + if (likely(super)) { > + func->function.ssp_descriptors = > + usb_copy_descriptors(func->function.ss_descriptors); > + } > /* And we're done */ > ffs_event_add(ffs, FUNCTIONFS_BIND); > return 0; > -- Hi Greg, FWIW I had sent a very similar patch[1] a while back (twice in fact) but got no response about it. Looks like Taehyun's patch already went through Google for this, I assume it must be working on their Android kernels so I've no problem with you or Felipe taking this instead. Only one difference with my patch though is mine additionally clears the func->function.ssp_descriptors member to NULL upon ffs_func_unbind() as otherwise it could lead to a dangling reference in case the function is re-bound and userspace does not issue SS descriptors the next time. Realistically I don't think that's possible, except maybe when fuzzing? [1] https://patchwork.kernel.org/project/linux-usb/patch/20201027230731.9073-1-jackp@codeaurora.org/ Jack -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project