Re: [PATCH 02/18] property: Add support for calling fwnode_graph_get_endpoint_by_id() for fwnode->secondary

Laurent Pinchart
2020-11-30T16:09:43Z

Hi Daniel,

Thank you for the patch.

On Mon, Nov 30, 2020 at 01:31:13PM +0000, Daniel Scally wrote:
> This function is used to find fwnode endpoints against a device. In
> some instances those endpoints are software nodes which are children of
> fwnode->secondary. Add support to fwnode_graph_get_endpoint_by_id() to
> find those endpoints by recursively calling itself passing the ptr to
> fwnode->secondary in the event no endpoint is found for the primary.
>
> Signed-off-by: Daniel Scally <djrscally@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Changes since RFC v3:
>
> Patch introduced. In discussion in the last submission I noted
> that the CIO2 device doesn't have an ACPI fwnode - that turns
> out to be true for _some_ devices but not others, so we need
> this function to check the secondary too.
>
> drivers/base/property.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index a5ca2306796f..4ece6b086e36 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -1162,6 +1162,10 @@ fwnode_graph_get_endpoint_by_id(const struct fwnode_handle *fwnode,
> best_ep_id = fwnode_ep.id;
> }
>
> + if (!best_ep && fwnode && !IS_ERR_OR_NULL(fwnode->secondary))
> + return fwnode_graph_get_endpoint_by_id(fwnode->secondary, port,
> + endpoint, flags);
> +
> return best_ep;
> }
> EXPORT_SYMBOL_GPL(fwnode_graph_get_endpoint_by_id);

--
Regards,

Laurent Pinchart