From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7B1C71155 for ; Mon, 30 Nov 2020 17:36:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DC8E206DF for ; Mon, 30 Nov 2020 17:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387736AbgK3RgU (ORCPT ); Mon, 30 Nov 2020 12:36:20 -0500 Received: from mga05.intel.com ([192.55.52.43]:16886 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387579AbgK3RgT (ORCPT ); Mon, 30 Nov 2020 12:36:19 -0500 IronPort-SDR: VFI9a2jaQ1qkLsL4ay+s+CIPEYmoLu57QZ61C9EKfWPAv+VQs9X3AlBCyaloENj/jCkPk5sWF6 XgZnLhaVIrFg== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="257383370" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="257383370" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 09:34:37 -0800 IronPort-SDR: xKJUjQ8laE51Ag27+DBSeh0uh0HukOeHAEfSp51gl9McS9F+Dcgy9QWC1bmPWGjS3LXy8cShle kv0Rpm1rzH7Q== X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="345143661" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 09:34:30 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kjn5G-00B62N-Dw; Mon, 30 Nov 2020 19:35:30 +0200 Date: Mon, 30 Nov 2020 19:35:30 +0200 From: Andy Shevchenko To: Daniel Scally Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, devel@acpica.org, rjw@rjwysocki.net, lenb@kernel.org, gregkh@linuxfoundation.org, mika.westerberg@linux.intel.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, wsa@kernel.org, yong.zhi@intel.com, sakari.ailus@linux.intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org, robert.moore@intel.com, erik.kaneda@intel.com, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, linux@rasmusvillemoes.dk, kieran.bingham+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, laurent.pinchart+renesas@ideasonboard.com, jorhand@linux.microsoft.com, kitakar@gmail.com, heikki.krogerus@linux.intel.com Subject: Re: [PATCH 04/18] software_node: Enforce parent before child ordering of nodes array for software_node_register_nodes() Message-ID: <20201130173530.GO4077@smile.fi.intel.com> References: <20201130133129.1024662-1-djrscally@gmail.com> <20201130133129.1024662-5-djrscally@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201130133129.1024662-5-djrscally@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 30, 2020 at 01:31:15PM +0000, Daniel Scally wrote: > Registering software_nodes with the .parent member set to point to a > currently unregistered software_node has the potential for problems, > so enforce parent -> child ordering in arrays passed to this function. I agree with Laurent. ... > for (i = 0; nodes[i].name; i++) { > + if (nodes[i].parent) > + if (!software_node_to_swnode(nodes[i].parent)) { > + ret = -EINVAL; > + goto err_unregister_nodes; > + } > + Besides that can we pack these conditionals together? if (nodes[i].parent && !software_node_to_swnode(nodes[i].parent)) { Do we have sane ordering in software_node_unregister_nodes()? -- With Best Regards, Andy Shevchenko