From: Eric Lin <tesheng@andestech.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"walken@google.com" <walken@google.com>,
"daniel.m.jordan@oracle.com" <daniel.m.jordan@oracle.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"penberg@kernel.org" <penberg@kernel.org>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"dslin1010@gmail.com" <dslin1010@gmail.com>,
"Alan Quey-Liang Kao(?????})" <alankao@andestech.com>
Subject: Re: [PATCH] riscv/mm: Prevent kernel module access user-space memory without uaccess routines
Date: Tue, 1 Dec 2020 13:20:49 +0800 [thread overview]
Message-ID: <20201201052048.GA7647@atcfdc88> (raw)
In-Reply-To: <20201130083015.GA14676@infradead.org>
On Mon, Nov 30, 2020 at 04:30:15PM +0800, Christoph Hellwig wrote:
Hi Christoph,
> > + if (!user_mode(regs) && addr < TASK_SIZE && unlikely(!(regs->status & SR_SUM)))
>
> Please avoid the overly long line.
OK, I'll modify it in v2. Thanks for your review.
prev parent reply other threads:[~2020-12-01 5:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 5:30 [PATCH] riscv/mm: Prevent kernel module access user-space memory without uaccess routines Eric Lin
2020-11-30 8:07 ` Pekka Enberg
2020-12-01 5:32 ` Eric Lin
2020-11-30 8:30 ` Christoph Hellwig
2020-12-01 5:20 ` Eric Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201052048.GA7647@atcfdc88 \
--to=tesheng@andestech.com \
--cc=akpm@linux-foundation.org \
--cc=alankao@andestech.com \
--cc=aou@eecs.berkeley.edu \
--cc=daniel.m.jordan@oracle.com \
--cc=dslin1010@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=penberg@kernel.org \
--cc=peterx@redhat.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox