linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Elia Devito <eliadevito@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: mario.limonciello@dell.com, Elia Devito <eliadevito@gmail.com>,
	Alex Hung <alex.hung@canonical.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <mgross@linux.intel.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] intel-hid: disable switches on Dell Latitute 7410 2in1
Date: Tue,  1 Dec 2020 20:57:00 +0100	[thread overview]
Message-ID: <20201201195659.22568-1-eliadevito@gmail.com> (raw)

Disable switches on Dell Latitute 7410 2in1 due firmware bug

Signed-off-by: Elia Devito <eliadevito@gmail.com>
---
maybe Mario Limonciello can help on this

 drivers/platform/x86/intel-hid.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
index 54f5cbfd2189..dc82415abd24 100644
--- a/drivers/platform/x86/intel-hid.c
+++ b/drivers/platform/x86/intel-hid.c
@@ -105,6 +105,22 @@ static const struct dmi_system_id button_array_switches_table[] = {
 	{ }
 };
 
+static const struct dmi_system_id button_array_switches_disable[] = {
+	{
+		/*
+		 * Dell Latitute 7410 2in1 emit wrong event and VGBS method return wrong
+		 * value when booted with AC adapter plugged-in, disable switches to
+		 * prevent wrong beaviour.
+		 */
+		.ident = "Dell Latitute 7410 2in1",
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 7410"),
+		},
+	},
+	{ }
+};
+
 #define KEYMAP_LEN \
 	(ARRAY_SIZE(intel_array_keymap) + ARRAY_SIZE(intel_array_switches) + 1)
 
@@ -515,7 +531,8 @@ static bool intel_button_array_has_switches(struct platform_device *device)
 		return false;
 
 	if (tablet_mode_switch != 1) {
-		if (!dmi_check_system(button_array_switches_table))
+		if (!dmi_check_system(button_array_switches_table) ||
+				dmi_check_system(button_array_switches_disable))
 			return false;
 	}
 
-- 
2.28.0


                 reply	other threads:[~2020-12-01 19:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201201195659.22568-1-eliadevito@gmail.com \
    --to=eliadevito@gmail.com \
    --cc=alex.hung@canonical.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@dell.com \
    --cc=mgross@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).