From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D20BBC64E8A for ; Wed, 2 Dec 2020 04:39:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CC39221FE for ; Wed, 2 Dec 2020 04:39:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728287AbgLBEj3 (ORCPT ); Tue, 1 Dec 2020 23:39:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725902AbgLBEj2 (ORCPT ); Tue, 1 Dec 2020 23:39:28 -0500 Received: from mail-oo1-xc43.google.com (mail-oo1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6CA7C0617A7 for ; Tue, 1 Dec 2020 20:38:42 -0800 (PST) Received: by mail-oo1-xc43.google.com with SMTP id h10so68539ooi.10 for ; Tue, 01 Dec 2020 20:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=x1J3oNmVed248Yr9F5ZYzVm9O5TAhAVtwD5WiYXieTM=; b=F+AKOO9pCQYn+/ifh4mIPLaNGJeZOmCjEmugX5tFpb9lYUHnjS2it5tO/q/+wG1ydu lFRspQVR9vHZESpQp704H+GmCG6Y2dZNpC1V7geaJ6Sfias1JxAVnZZ3nwM+nVKiHdFO jUJwHca8YVoRdcIbitwfD4fXb0kyD/4fFBouah6Qm8FkQF/3HrfJZiiOjyFvybA/KTh3 iRTj4CoX9so9c979DLUpbErKqUIzfmFPW5oALfrik8Ff3DIukUryeeQH7C8NOPQW+PN9 Gm6mhb/OT63IgVcQdbaUJIrPMqzAtxn3Lx72SKmAq2Kq/OUlrmqpwRnikidNZsieZTfU lusg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=x1J3oNmVed248Yr9F5ZYzVm9O5TAhAVtwD5WiYXieTM=; b=qyKm5ngwNntP6c5Tws+lSgEp9PEkt/hPvgNmFXwm8AtH/k9lsZdOICweMwQDvhYq7O 32k5OMXcPzthFXYDTI7ysp9oTZAvLwgZvotfTYAfBO/XPkwIWULKMCIMpd3TSuSxL6Lr iIQLH7yKIUbKZvBS/y4qFXx6mkJIjQCvzcnDQYjsgP8VoXCkPNqoIodRc4GWz+K9SygE kTUnIsgdLxYPwXQNzpI+/DKPQQzBsST9MihRiXnpt08v0ucPZ7cPFyoRPg5lgW5yBK87 n64nD7EMh5kwX9u3zsKnuDabOXlMOEYEfHbTjvrvXwkDZKOLxWMpATuzxcfdN5mXMaR7 aBBw== X-Gm-Message-State: AOAM5334bmHfg2cUIQ5nHE9wiJ7qj19Fm5WpLLTU7srVXzXGM9lRBRJW GzflHd0cIzXno+rjD1Oi9uqSdg== X-Google-Smtp-Source: ABdhPJx3n5GPkA/PmFkRvvmtFHgXXxzuijf/+FpB+95yB2JyUbQkL9apmio7/pw3Zua14/43WG0sig== X-Received: by 2002:a05:6820:351:: with SMTP id m17mr405037ooe.36.1606883921962; Tue, 01 Dec 2020 20:38:41 -0800 (PST) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id y18sm122944ooj.20.2020.12.01.20.38.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 20:38:41 -0800 (PST) Date: Tue, 1 Dec 2020 22:38:39 -0600 From: Bjorn Andersson To: Jakub Kicinski Cc: Hemant Kumar , manivannan.sadhasivam@linaro.org, gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, jhugo@codeaurora.org, bbhatt@codeaurora.org, loic.poulain@linaro.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Kalle Valo Subject: Re: [PATCH v13 0/4] userspace MHI client interface driver Message-ID: <20201202043839.GL807@yoga> References: <1606533966-22821-1-git-send-email-hemantk@codeaurora.org> <20201201112901.7f13e26c@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201201112901.7f13e26c@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 01 Dec 13:29 CST 2020, Jakub Kicinski wrote: > On Fri, 27 Nov 2020 19:26:02 -0800 Hemant Kumar wrote: > > This patch series adds support for UCI driver. UCI driver enables userspace > > clients to communicate to external MHI devices like modem and WLAN. UCI driver > > probe creates standard character device file nodes for userspace clients to > > perform open, read, write, poll and release file operations. These file > > operations call MHI core layer APIs to perform data transfer using MHI bus > > to communicate with MHI device. Patch is tested using arm64 based platform. > > Wait, I thought this was for modems. > No, this allows exposing particular channels from any type of MHI devices. For modems there is a legacy control path that uses UCI. But data traffic, (non-legacy) modem control signals and e.g the bearer of GPS data uses in-kernel drivers that are already in place. > Why do WLAN devices need to communicate with user space? They normally don't, all WLAN operations are dealt with within the kernel. The use case that comes to mind for UCI when it comes to WiFi products is to avoid implementing the Qualcomm debug (diag) protocol in the kernel. As such I think saying that it can be used to communicate with modem or WLAN devices is misleading. Because while it could be done, it is only used for dealing with optional side-band services on such products - not the actual WiFi and modem functionality. Regards, Bjorn