From: Andi Kleen <ak@linux.intel.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jin Yao <yao.jin@linux.intel.com>,
John Garry <john.garry@huawei.com>, Paul Clarke <pc@us.ibm.com>,
kajoljain <kjain@linux.ibm.com>,
Stephane Eranian <eranian@google.com>,
Sandeep Dasgupta <sdasgup@google.com>
Subject: Re: [PATCH v4 5/5] perf metric: Don't compute unused events.
Date: Tue, 1 Dec 2020 22:55:26 -0800 [thread overview]
Message-ID: <20201202065526.GE1363814@tassilo.jf.intel.com> (raw)
In-Reply-To: <CAP-5=fVMuRCZEyG+s3z2gw3OvcDdtE1Kwe-7LG7uXOKfwmzFcA@mail.gmail.com>
> Can't this be all in a macro? It's still a lot of duplication.
>
> I'm still not a fan, but I think with a macro it wouldn't be too bad.
>
> Ugh, not a fan of macros. They expand to a single line of code and make
> debugging hard. I'll do a v5 with a macro :-/
I suppose you could inlines with callbacks too, with one liner functions for
the operands.
-Andi
prev parent reply other threads:[~2020-12-02 6:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 6:26 [PATCH v4 0/5] Don't compute events that won't be used in a metric Ian Rogers
2020-12-02 6:26 ` [PATCH v4 1/5] perf metric: Restructure struct expr_parse_ctx Ian Rogers
2020-12-02 6:26 ` [PATCH v4 2/5] perf metric: Use NAN for missing event IDs Ian Rogers
2020-12-02 6:26 ` [PATCH v4 3/5] perf metric: Rename expr__find_other Ian Rogers
2020-12-02 6:26 ` [PATCH v4 4/5] perf metric: Add utilities to work on ids map Ian Rogers
2020-12-02 6:26 ` [PATCH v4 5/5] perf metric: Don't compute unused events Ian Rogers
2020-12-02 6:36 ` Andi Kleen
[not found] ` <CAP-5=fVMuRCZEyG+s3z2gw3OvcDdtE1Kwe-7LG7uXOKfwmzFcA@mail.gmail.com>
2020-12-02 6:55 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202065526.GE1363814@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=sdasgup@google.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox