From: Kees Cook <keescook@chromium.org>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Randy Dunlap <rdunlap@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: [PATCH v3] x86/pci: fix the function type for check_reserved_t
Date: Wed, 2 Dec 2020 11:39:52 -0800 [thread overview]
Message-ID: <202012021139.FC8F149@keescook> (raw)
In-Reply-To: <20201130193900.456726-1-samitolvanen@google.com>
On Mon, Nov 30, 2020 at 11:39:00AM -0800, Sami Tolvanen wrote:
> e820__mapped_all is passed as a callback to is_mmconf_reserved,
> which expects a function of type:
>
> typedef bool (*check_reserved_t)(u64 start, u64 end, unsigned type);
>
> However, e820__mapped_all accepts enum e820_type as the last
> argument and this type mismatch trips indirect call checking with
> Clang's Control-Flow Integrity (CFI).
>
> As is_mmconf_reserved only passes enum e820_type values for the
> type argument, change the typedef and the unused type argument in
> is_acpi_reserved to enum e820_type to fix the type mismatch.
>
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Suggested-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2020-12-02 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 19:39 [PATCH v3] x86/pci: fix the function type for check_reserved_t Sami Tolvanen
2020-12-01 14:21 ` [tip: x86/misc] x86/pci: Fix " tip-bot2 for Sami Tolvanen
2020-12-02 19:39 ` Kees Cook [this message]
2020-12-04 8:47 ` [PATCH v3] x86/pci: fix " Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012021139.FC8F149@keescook \
--to=keescook@chromium.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=samitolvanen@google.com \
--cc=sedat.dilek@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox