From: Wolfram Sang <wsa@kernel.org>
To: Youling Tang <tangyouling@loongson.cn>
Cc: Seth Heasley <seth.heasley@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: busses: Use dma_set_mask_and_coherent
Date: Wed, 2 Dec 2020 17:01:47 +0100 [thread overview]
Message-ID: <20201202160147.GG13425@kunai> (raw)
In-Reply-To: <1606223315-13390-1-git-send-email-tangyouling@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
On Tue, Nov 24, 2020 at 09:08:35PM +0800, Youling Tang wrote:
> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
>
> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
Please use "i2c: ismt:", so driver maintainers know that the patch is
relevant to them.
> ---
> drivers/i2c/busses/i2c-ismt.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index a35a27c..5f49830 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -903,16 +903,12 @@ ismt_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> return -ENODEV;
> }
>
> - if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(64)) != 0) ||
> - (pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64)) != 0)) {
> - if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)) != 0) ||
> - (pci_set_consistent_dma_mask(pdev,
> - DMA_BIT_MASK(32)) != 0)) {
> + if (dma_set_mask_and_coherent(pdev, DMA_BIT_MASK(64)) != 0)
> + if (dma_set_mask_and_coherent(pdev, DMA_BIT_MASK(32)) != 0) {
> dev_err(&pdev->dev, "pci_set_dma_mask fail %p\n",
> pdev);
> return -ENODEV;
> }
> - }
>
> err = ismt_dev_init(priv);
> if (err)
> --
> 2.1.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-02 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 13:08 [PATCH] i2c: busses: Use dma_set_mask_and_coherent Youling Tang
2020-12-02 16:01 ` Wolfram Sang [this message]
2020-12-03 0:51 ` Youling Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202160147.GG13425@kunai \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=seth.heasley@intel.com \
--cc=tangyouling@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox