* [PATCH] i2c: busses: Use dma_set_mask_and_coherent
@ 2020-11-24 13:08 Youling Tang
2020-12-02 16:01 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Youling Tang @ 2020-11-24 13:08 UTC (permalink / raw)
To: Seth Heasley, Neil Horman; +Cc: linux-i2c, linux-kernel
'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
Signed-off-by: Youling Tang <tangyouling@loongson.cn>
---
drivers/i2c/busses/i2c-ismt.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
index a35a27c..5f49830 100644
--- a/drivers/i2c/busses/i2c-ismt.c
+++ b/drivers/i2c/busses/i2c-ismt.c
@@ -903,16 +903,12 @@ ismt_probe(struct pci_dev *pdev, const struct pci_device_id *id)
return -ENODEV;
}
- if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(64)) != 0) ||
- (pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64)) != 0)) {
- if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)) != 0) ||
- (pci_set_consistent_dma_mask(pdev,
- DMA_BIT_MASK(32)) != 0)) {
+ if (dma_set_mask_and_coherent(pdev, DMA_BIT_MASK(64)) != 0)
+ if (dma_set_mask_and_coherent(pdev, DMA_BIT_MASK(32)) != 0) {
dev_err(&pdev->dev, "pci_set_dma_mask fail %p\n",
pdev);
return -ENODEV;
}
- }
err = ismt_dev_init(priv);
if (err)
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: busses: Use dma_set_mask_and_coherent
2020-11-24 13:08 [PATCH] i2c: busses: Use dma_set_mask_and_coherent Youling Tang
@ 2020-12-02 16:01 ` Wolfram Sang
2020-12-03 0:51 ` Youling Tang
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2020-12-02 16:01 UTC (permalink / raw)
To: Youling Tang; +Cc: Seth Heasley, Neil Horman, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
On Tue, Nov 24, 2020 at 09:08:35PM +0800, Youling Tang wrote:
> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
>
> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
Please use "i2c: ismt:", so driver maintainers know that the patch is
relevant to them.
> ---
> drivers/i2c/busses/i2c-ismt.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index a35a27c..5f49830 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -903,16 +903,12 @@ ismt_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> return -ENODEV;
> }
>
> - if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(64)) != 0) ||
> - (pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64)) != 0)) {
> - if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)) != 0) ||
> - (pci_set_consistent_dma_mask(pdev,
> - DMA_BIT_MASK(32)) != 0)) {
> + if (dma_set_mask_and_coherent(pdev, DMA_BIT_MASK(64)) != 0)
> + if (dma_set_mask_and_coherent(pdev, DMA_BIT_MASK(32)) != 0) {
> dev_err(&pdev->dev, "pci_set_dma_mask fail %p\n",
> pdev);
> return -ENODEV;
> }
> - }
>
> err = ismt_dev_init(priv);
> if (err)
> --
> 2.1.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: busses: Use dma_set_mask_and_coherent
2020-12-02 16:01 ` Wolfram Sang
@ 2020-12-03 0:51 ` Youling Tang
0 siblings, 0 replies; 3+ messages in thread
From: Youling Tang @ 2020-12-03 0:51 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Seth Heasley, Neil Horman, linux-i2c, linux-kernel
Hi, Wolfram
On 12/03/2020 12:01 AM, Wolfram Sang wrote:
> On Tue, Nov 24, 2020 at 09:08:35PM +0800, Youling Tang wrote:
>> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
>> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
>>
>> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
> Please use "i2c: ismt:", so driver maintainers know that the patch is
> relevant to them.
Thank you for your suggestion, I'll send v2 later.
Thanks.
Youling.
>> ---
>> drivers/i2c/busses/i2c-ismt.c | 8 ++------
>> 1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
>> index a35a27c..5f49830 100644
>> --- a/drivers/i2c/busses/i2c-ismt.c
>> +++ b/drivers/i2c/busses/i2c-ismt.c
>> @@ -903,16 +903,12 @@ ismt_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>> return -ENODEV;
>> }
>>
>> - if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(64)) != 0) ||
>> - (pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64)) != 0)) {
>> - if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)) != 0) ||
>> - (pci_set_consistent_dma_mask(pdev,
>> - DMA_BIT_MASK(32)) != 0)) {
>> + if (dma_set_mask_and_coherent(pdev, DMA_BIT_MASK(64)) != 0)
>> + if (dma_set_mask_and_coherent(pdev, DMA_BIT_MASK(32)) != 0) {
>> dev_err(&pdev->dev, "pci_set_dma_mask fail %p\n",
>> pdev);
>> return -ENODEV;
>> }
>> - }
>>
>> err = ismt_dev_init(priv);
>> if (err)
>> --
>> 2.1.0
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-03 0:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-24 13:08 [PATCH] i2c: busses: Use dma_set_mask_and_coherent Youling Tang
2020-12-02 16:01 ` Wolfram Sang
2020-12-03 0:51 ` Youling Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox