Re: [PATCH] media: venus: preserve DRC state across seeks

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3695 bytes --]

Hi Alexandre,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.10-rc6 next-20201201]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alexandre-Courbot/media-venus-preserve-DRC-state-across-seeks/20201202-133933
base:   git://linuxtv.org/media_tree.git master
config: m68k-randconfig-r003-20201201 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8ca3c23e59a3bb6c00e6d70a1de927c1558b6b32
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alexandre-Courbot/media-venus-preserve-DRC-state-across-seeks/20201202-133933
        git checkout 8ca3c23e59a3bb6c00e6d70a1de927c1558b6b32
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/media/platform/qcom/venus/vdec.c: In function 'vdec_start_output':
>> drivers/media/platform/qcom/venus/vdec.c:975:11: error: 'struct venus_inst' has no member named 'next_buf_last'
     975 |   if (inst->next_buf_last)
         |           ^~
   drivers/media/platform/qcom/venus/vdec.c: In function 'vdec_event_change':
   drivers/media/platform/qcom/venus/vdec.c:1380:6: error: 'struct venus_inst' has no member named 'next_buf_last'
    1380 |  inst->next_buf_last = true;
         |      ^~

vim +975 drivers/media/platform/qcom/venus/vdec.c

   968	
   969	static int vdec_start_output(struct venus_inst *inst)
   970	{
   971		int ret;
   972	
   973		if (inst->codec_state == VENUS_DEC_STATE_SEEK) {
   974			ret = venus_helper_process_initial_out_bufs(inst);
 > 975			if (inst->next_buf_last)
   976				inst->codec_state = VENUS_DEC_STATE_DRC;
   977			else
   978				inst->codec_state = VENUS_DEC_STATE_DECODING;
   979			goto done;
   980		}
   981	
   982		if (inst->codec_state == VENUS_DEC_STATE_INIT ||
   983		    inst->codec_state == VENUS_DEC_STATE_CAPTURE_SETUP) {
   984			ret = venus_helper_process_initial_out_bufs(inst);
   985			goto done;
   986		}
   987	
   988		if (inst->codec_state != VENUS_DEC_STATE_DEINIT)
   989			return -EINVAL;
   990	
   991		venus_helper_init_instance(inst);
   992		inst->sequence_out = 0;
   993		inst->reconfig = false;
   994	
   995		ret = vdec_set_properties(inst);
   996		if (ret)
   997			return ret;
   998	
   999		ret = vdec_output_conf(inst);
  1000		if (ret)
  1001			return ret;
  1002	
  1003		ret = vdec_verify_conf(inst);
  1004		if (ret)
  1005			return ret;
  1006	
  1007		ret = venus_helper_set_num_bufs(inst, inst->num_input_bufs,
  1008						VB2_MAX_FRAME, VB2_MAX_FRAME);
  1009		if (ret)
  1010			return ret;
  1011	
  1012		ret = venus_helper_vb2_start_streaming(inst);
  1013		if (ret)
  1014			return ret;
  1015	
  1016		ret = venus_helper_process_initial_out_bufs(inst);
  1017		if (ret)
  1018			return ret;
  1019	
  1020		inst->codec_state = VENUS_DEC_STATE_INIT;
  1021	
  1022	done:
  1023		inst->streamon_out = 1;
  1024		return ret;
  1025	}
  1026	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37258 bytes --]