Re: [tip: x86/urgent] x86/uprobes: Do not use prefixes.nbytes when looping over prefixes.bytes

Arnaldo Carvalho de Melo
2020-12-09T18:02:36Z

Em Sun, Dec 06, 2020 at 10:02:50AM +0100, Borislav Petkov escreveu:
> ( drop stable@ )
>
> On Sun, Dec 06, 2020 at 12:53:25PM +0900, Masami Hiramatsu wrote:
> > On Sat, 5 Dec 2020 11:17:04 +0100
> > Borislav Petkov <bp@alien8.de> wrote:
> >
> > > On Sat, Dec 05, 2020 at 09:12:56AM +0900, Masami Hiramatsu wrote:
> > > > This may break tools/objtool build. Please keep "inat.h".
> > >
> > > How? Please elaborate.
> > >
> > > Build tests are fine here.
> >
> > Oops, sorry, it was for perf build.
> >
> > Please refer commit 00a263902ac3 ("perf intel-pt: Use shared x86 insn decoder").
>
> Oh wow:
>
> "This way we continue to be able to process perf.data files with Intel PT
> traces in distros other than x86."
>
> acme, why is that? Can you explain pls?
>
> It probably would be better to fix this so that copying insn.h to keep
> it in sync won't cause any future breakages. Or the diffing check should
> verify whether header paths are wrong in the tools/ version and fail if
> so, so that we don't break it.

Trying to swap this back into my brain...

Humm, if I'm building this on, say, aarch64 then asm/ will not be
pointing to x86, right? Intel PT needs the x86 instruction decoder,
right?

I should've have wrote in the cset comment log if this was related to
cross build failures I encountered, can't remember now :-\

- Arnaldo