From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1598C43211 for ; Thu, 3 Dec 2020 14:12:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2603A20705 for ; Thu, 3 Dec 2020 14:12:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727126AbgLCOMK convert rfc822-to-8bit (ORCPT ); Thu, 3 Dec 2020 09:12:10 -0500 Received: from mail-ej1-f67.google.com ([209.85.218.67]:34795 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbgLCOMJ (ORCPT ); Thu, 3 Dec 2020 09:12:09 -0500 Received: by mail-ej1-f67.google.com with SMTP id g20so3707340ejb.1 for ; Thu, 03 Dec 2020 06:11:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HvFZiSMhoT0aeyub9btQ17rJWqEcfPqD1vSkkC2bi6U=; b=MbwZCyaXiJ7bBnr3Hv0pArt6sYqJvvdnwOzV5eChpugAMEoNeIVAYj84qPJjnMHVJZ XWVdpTdMiz5fuLfnBEAVs7+HXAVCVhJlzGmVu62HD4fwHh2tIE7lffCdNzfAmlY0MO1w f+OWUdQtjXQ1xcsu3IRIPSDp5FtC/II716jQJugR2omI48aQ8Ioa+Ph85a2yYG33Ou1U Jczv/UDn6zfHox/6R7dBnE503D4V+hzjwKu+zww4uxJIW2tMovrzv6y3QBtiyc4v//C0 /4yfIvzo3o1wcM0C75UmcFmhySwcpx7xZsKjNwriWUY/NEExn/Fj/uxU/2UE9/5FyuYl fT2w== X-Gm-Message-State: AOAM533GaDp5VpGTOMSmKgPqzTFHNITU3ruikIjgRcX7R+z9HYPQr6bu bZNL2NDBAmanpMwnnZafqZo= X-Google-Smtp-Source: ABdhPJwmTL7CqlVMbcxOkKjnuwYYIrLWmt7q2Iqbg4wZ3SjdKguBUGw7iF61U1RnqWFHNlGYLe8sew== X-Received: by 2002:a17:906:edb2:: with SMTP id sa18mr2580951ejb.264.1607004686773; Thu, 03 Dec 2020 06:11:26 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id t26sm1256930edt.69.2020.12.03.06.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 06:11:25 -0800 (PST) Date: Thu, 3 Dec 2020 16:11:23 +0200 From: Krzysztof Kozlowski To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Matt Mackall , Herbert Xu , Dan Williams , Vinod Koul , Eric Anholt , David Airlie , Daniel Vetter , Alexander Shishkin , Linus Walleij , Dmitry Torokhov , Ulf Hansson , Alexandre Belloni , Mark Brown , Greg Kroah-Hartman , Jiri Slaby , Alex Williamson , Cornelia Huck , Wim Van Sebroeck , Guenter Roeck , Jaroslav Kysela , Takashi Iwai , Russell King , Arnd Bergmann , Rob Herring , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] amba: Make the remove callback return void Message-ID: <20201203141123.GA7735@kozik-lap> References: <20201124133139.3072124-1-uwe@kleine-koenig.org> <20201124133139.3072124-5-uwe@kleine-koenig.org> <20201203130141.ys2s7aaltyzkdena@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20201203130141.ys2s7aaltyzkdena@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 03, 2020 at 02:01:41PM +0100, Uwe Kleine-König wrote: > Hello, > > [This is a resend because somehow my MUA failed to parse the To: list > and dropped it without me noticing it. Sorry to those who got it twice > now.] > > On Tue, Nov 24, 2020 at 02:31:38PM +0100, Uwe Kleine-König wrote: > > From: Uwe Kleine-König > > > > All amba drivers return 0 in their remove callback. Together with the > > driver core ignoring the return value anyhow, it doesn't make sense to > > return a value here. > > > > Change the remove prototype to return void, which makes it explicit that > > returning an error value doesn't work as expected. This simplifies changing > > the core remove callback to return void, too. > > > > Reviewed-by: Ulf Hansson > > Reviewed-by: Arnd Bergmann > > Signed-off-by: Uwe Kleine-König > > --- > > drivers/amba/bus.c | 5 ++--- > > drivers/char/hw_random/nomadik-rng.c | 3 +-- > > drivers/dma/pl330.c | 3 +-- > > drivers/gpu/drm/pl111/pl111_drv.c | 4 +--- > > drivers/hwtracing/coresight/coresight-catu.c | 3 +-- > > drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 +--- > > drivers/hwtracing/coresight/coresight-cti-core.c | 4 +--- > > drivers/hwtracing/coresight/coresight-etb10.c | 4 +--- > > drivers/hwtracing/coresight/coresight-etm3x-core.c | 4 +--- > > drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +--- > > drivers/hwtracing/coresight/coresight-funnel.c | 4 ++-- > > drivers/hwtracing/coresight/coresight-replicator.c | 4 ++-- > > drivers/hwtracing/coresight/coresight-stm.c | 4 +--- > > drivers/hwtracing/coresight/coresight-tmc-core.c | 4 +--- > > drivers/hwtracing/coresight/coresight-tpiu.c | 4 +--- > > drivers/i2c/busses/i2c-nomadik.c | 4 +--- > > drivers/input/serio/ambakmi.c | 3 +-- > > drivers/memory/pl172.c | 4 +--- > > drivers/memory/pl353-smc.c | 4 +--- For the memory: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof