From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A9AFC4361A for ; Thu, 3 Dec 2020 15:24:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F09C220709 for ; Thu, 3 Dec 2020 15:24:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387692AbgLCPYo (ORCPT ); Thu, 3 Dec 2020 10:24:44 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:36680 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726751AbgLCPYo (ORCPT ); Thu, 3 Dec 2020 10:24:44 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kkqSQ-00A3ZL-1W; Thu, 03 Dec 2020 16:23:46 +0100 Date: Thu, 3 Dec 2020 16:23:46 +0100 From: Andrew Lunn To: Wang Hai Cc: davem@davemloft.net, kuba@kernel.org, rmk+kernel@armlinux.org.uk, mcroce@microsoft.com, sven.auhagen@voleatech.de, atenart@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: mvpp2: Fix error return code in mvpp2_open() Message-ID: <20201203152346.GP2324545@lunn.ch> References: <20201203141806.37966-1-wanghai38@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201203141806.37966-1-wanghai38@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 03, 2020 at 10:18:06PM +0800, Wang Hai wrote: > Fix to return negative error code -ENOENT from invalid configuration > error handling case instead of 0, as done elsewhere in this function. > > Fixes: 4bb043262878 ("net: mvpp2: phylink support") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Reviewed-by: Andrew Lunn Andrew