From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH 2/2] MIPS: Select ARCH_KEEP_MEMBLOCK to enable sysfs memblock debug
Date: Fri, 4 Dec 2020 13:08:16 +0100 [thread overview]
Message-ID: <20201204120816.GC10011@alpha.franken.de> (raw)
In-Reply-To: <9c9af0de-387b-f113-b0a2-c5767c31c16d@flygoat.com>
On Thu, Dec 03, 2020 at 11:58:51AM +0800, Jiaxun Yang wrote:
>
>
> 在 2020/12/3 上午11:19, Tiezhu Yang 写道:
> > In the current code, CONFIG_ARCH_KEEP_MEMBLOCK is not set for MIPS arch,
> > memblock_discard() will discard memory and reserved arrays if they were
> > allocated, select ARCH_KEEP_MEMBLOCK to give a chance to track "memory"
> > and "reserved" memblocks after early boot, with this patch, we can see
> > the following two sysfs interfaces under DEBUG_FS.
> >
> > /sys/kernel/debug/memblock/memory
> > /sys/kernel/debug/memblock/reserved
>
> Is this really necessary?
> memblock data is not really necessary after boot for non-debug purpose.
>
> Given that MIPS is widely used in embedded systems which doesn't have much
> memory, keeping unused data after boot is kinda unconvincing.
about how much memory are talking here ?
>
> If you intend to debug that please do it locally.
maybe we can add a
if DEBUG_KERNEL
since enabling DEBUG_KERNEL will cost already some memory...
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2020-12-04 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 3:19 [PATCH 0/2] memblock debug Tiezhu Yang
2020-12-03 3:19 ` [PATCH 1/2] MIPS: Move memblock_dump_all() to the end of setup_arch() Tiezhu Yang
2020-12-04 12:07 ` Thomas Bogendoerfer
2020-12-03 3:19 ` [PATCH 2/2] MIPS: Select ARCH_KEEP_MEMBLOCK to enable sysfs memblock debug Tiezhu Yang
2020-12-03 3:58 ` Jiaxun Yang
2020-12-04 12:08 ` Thomas Bogendoerfer [this message]
2020-12-05 5:05 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204120816.GC10011@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox