From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58AC9C4167B for ; Fri, 4 Dec 2020 12:11:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 052AA22AEC for ; Fri, 4 Dec 2020 12:11:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730115AbgLDMKz (ORCPT ); Fri, 4 Dec 2020 07:10:55 -0500 Received: from elvis.franken.de ([193.175.24.41]:48097 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728306AbgLDMKy (ORCPT ); Fri, 4 Dec 2020 07:10:54 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kl9ud-0005Nb-04; Fri, 04 Dec 2020 13:10:11 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id EED0FC02E5; Fri, 4 Dec 2020 13:08:52 +0100 (CET) Date: Fri, 4 Dec 2020 13:08:52 +0100 From: Thomas Bogendoerfer To: Xingxing Su Cc: Youling Tang , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: Enable GCOV Message-ID: <20201204120852.GE10011@alpha.franken.de> References: <1606980171-9536-1-git-send-email-suxingxing@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1606980171-9536-1-git-send-email-suxingxing@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 03, 2020 at 03:22:51PM +0800, Xingxing Su wrote: > Enable gcov profiling of the entire kernel on mips. Required changes > include disabling profiling for: > > * arch/kernel/boot/compressed: not linked to main kernel. > > Lightly tested on Loongson 3A3000 an 3A4000, seems to work as expected. > > without "GCOV_PROFILE := n" in compressed Makefile, > build errors as follows: > ... > ld: arch/mips/boot/compressed/string.o:(.data+0x88): > undefined reference to `__gcov_merge_add' > ld: arch/mips/boot/compressed/string.o: > in function `_GLOBAL__sub_I_00100_0_memcpy': > string.c:(.text.startup+0x4): undefined reference to `__gcov_init' > ld: arch/mips/boot/compressed/string.o: > in function `_GLOBAL__sub_D_00100_1_memcpy': > string.c:(.text.exit+0x0): undefined reference to `__gcov_exit' > ... > > Signed-off-by: Youling Tang > Signed-off-by: Xingxing Su > --- > arch/mips/Kconfig | 1 + > arch/mips/boot/compressed/Makefile | 1 + > 2 files changed, 2 insertions(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]