From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Alexander A Sverdlin <alexander.sverdlin@nokia.com>
Cc: linux-mips@vger.kernel.org, Paul Burton <paulburton@kernel.org>,
Leonid Rosenboim <lrosenboim@caviumnetworks.com>,
Corey Minyard <cminyard@mvista.com>,
linux-kernel@vger.kernel.org,
Serge Semin <fancer.lancer@gmail.com>,
"Maciej W . Rozycki" <macro@linux-mips.org>,
Jinyang He <hejinyang@loongson.cn>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH 1/2] MIPS: Don't round up kernel sections size for memblock_add()
Date: Fri, 4 Dec 2020 13:09:32 +0100 [thread overview]
Message-ID: <20201204120932.GF10011@alpha.franken.de> (raw)
In-Reply-To: <20201203123649.44046-1-alexander.sverdlin@nokia.com>
On Thu, Dec 03, 2020 at 01:36:48PM +0100, Alexander A Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>
> Linux doesn't own the memory immediately after the kernel image. On Octeon
> bootloader places a shared structure right close after the kernel _end,
> refer to "struct cvmx_bootinfo *octeon_bootinfo" in cavium-octeon/setup.c.
>
> If check_kernel_sections_mem() rounds the PFNs up, first memblock_alloc()
> inside early_init_dt_alloc_memory_arch() <= device_tree_init() returns
> memory block overlapping with the above octeon_bootinfo structure, which
> is being overwritten afterwards.
>
> Fixes: a94e4f24ec83 ("MIPS: init: Drop boot_mem_map")
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> ---
> arch/mips/kernel/setup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2020-12-04 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 12:36 [PATCH 1/2] MIPS: Don't round up kernel sections size for memblock_add() Alexander A Sverdlin
2020-12-03 12:36 ` [PATCH 2/2] MIPS: OCTEON: Don't add kernel sections into memblock allocator Alexander A Sverdlin
2020-12-04 12:09 ` Thomas Bogendoerfer
2020-12-04 12:09 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204120932.GF10011@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=alexander.sverdlin@nokia.com \
--cc=cminyard@mvista.com \
--cc=fancer.lancer@gmail.com \
--cc=hejinyang@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lrosenboim@caviumnetworks.com \
--cc=macro@linux-mips.org \
--cc=paulburton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox