From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1A50C433FE for ; Fri, 4 Dec 2020 12:25:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AE81229EF for ; Fri, 4 Dec 2020 12:25:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730126AbgLDMZE (ORCPT ); Fri, 4 Dec 2020 07:25:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:49224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729749AbgLDMZE (ORCPT ); Fri, 4 Dec 2020 07:25:04 -0500 Date: Fri, 4 Dec 2020 09:24:30 -0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607084663; bh=Y1bMeJShgRce/XY+jTXwelWQ41TtFeAQ0C5dZ7g79U0=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=C9h9+kJVbWm2VNiFW/jlctf36I2M1h8T6vpP54557IBdWrP0I6z85HGT8V7pFjyh4 qBGV2JTxAog/Jd4EwhiNILatXaa9pY3GoAHWmJg+xfEmAY/lnxKVJ+03B7VZeoXkNH 36aFUKidJoyRXYaydR181KZoovYTBtLWUhSA9l+sn8d/MpFck0+FLY1jnMGuTl5wKn oWoFwb/jOr9IAf6EhMWopbKFkccsSAOjtx19jgKjkl1yn2Y0N1tgoBfjcEoAO5QVx5 mrUB5+Ju8OyPKGfk5/BGymTMdtsLpGAAcf/fH0CQ5U1SzdfJgpU+9nytdHmCjvyz9W CcaxhcsPgud2w== From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Namhyung Kim , Alexander Shishkin , Michael Petlan , Ian Rogers , Stephane Eranian Subject: Re: [PATCH] tools build: Add missing libcap to test-all.bin target Message-ID: <20201204122430.GA120850@kernel.org> References: <20201203230836.3751981-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201203230836.3751981-1-jolsa@kernel.org> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Dec 04, 2020 at 12:08:36AM +0100, Jiri Olsa escreveu: > We're missing -lcap in test-all.bin target, so in case it's > the only library missing (if more are missing test-all.bin > fails anyway), we will falsely claim that we detected it and > fail build, like: Thanks, applied. - Arnaldo > $ make > ... > Auto-detecting system features: > ... dwarf: [ on ] > ... dwarf_getlocations: [ on ] > ... glibc: [ on ] > ... libbfd: [ on ] > ... libbfd-buildid: [ on ] > ... libcap: [ on ] > ... libelf: [ on ] > ... libnuma: [ on ] > ... numa_num_possible_cpus: [ on ] > ... libperl: [ on ] > ... libpython: [ on ] > ... libcrypto: [ on ] > ... libunwind: [ on ] > ... libdw-dwarf-unwind: [ on ] > ... zlib: [ on ] > ... lzma: [ on ] > ... get_cpuid: [ on ] > ... bpf: [ on ] > ... libaio: [ on ] > ... libzstd: [ on ] > ... disassembler-four-args: [ on ] > > ... > > CC builtin-ftrace.o > > In file included from builtin-ftrace.c:29: > util/cap.h:11:10: fatal error: sys/capability.h: No such file or directory > 11 | #include > | ^~~~~~~~~~~~~~~~~~ > compilation terminated. > > Signed-off-by: Jiri Olsa > --- > tools/build/feature/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile > index cdde783f3018..89ba522e377d 100644 > --- a/tools/build/feature/Makefile > +++ b/tools/build/feature/Makefile > @@ -90,7 +90,7 @@ __BUILDXX = $(CXX) $(CXXFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$( > ############################### > > $(OUTPUT)test-all.bin: > - $(BUILD) -fstack-protector-all -O2 -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -I/usr/include/slang -lslang $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz -llzma -lzstd > + $(BUILD) -fstack-protector-all -O2 -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -I/usr/include/slang -lslang $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz -llzma -lzstd -lcap > > $(OUTPUT)test-hello.bin: > $(BUILD) > -- > 2.26.2 > -- - Arnaldo