From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE071C433FE for ; Sat, 5 Dec 2020 19:25:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90C2722C9F for ; Sat, 5 Dec 2020 19:25:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727213AbgLETZh (ORCPT ); Sat, 5 Dec 2020 14:25:37 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:54074 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgLETZg (ORCPT ); Sat, 5 Dec 2020 14:25:36 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id BAF51804C8; Sat, 5 Dec 2020 20:24:48 +0100 (CET) Date: Sat, 5 Dec 2020 20:24:47 +0100 From: Sam Ravnborg To: Douglas Anderson Cc: Thierry Reding , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: panel: Fully transition panel_desc kerneldoc to inline style Message-ID: <20201205192447.GD332836@ravnborg.org> References: <20201201125822.1.I3c4191336014bd57364309439e56f600c94bb12b@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201201125822.1.I3c4191336014bd57364309439e56f600c94bb12b@changeid> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Itgwjo3g c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=cm27Pg_UAAAA:8 a=pGLkceISAAAA:8 a=e5mUnYsNAAAA:8 a=z3ztCu_kXq1d7hxwpHYA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=xmb-EsYY8bH0VWELuYED:22 a=Vxmtnl_E_bksehYqCbjh:22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Douglas, On Tue, Dec 01, 2020 at 12:59:12PM -0800, Douglas Anderson wrote: > In commit 131f909ad55f ("drm: panel: simple: Fixup the struct > panel_desc kernel doc") I transitioned the more deeply nested > kerneldoc comments into the inline style. Apparently it is desirable > to continue the job and move _everything_ in this struct to inline. > Let's do it. > > While doing this, we also add a short summary for the whole struct to > fix a warning when we run with extra warnings, AKA: > scripts/kernel-doc -v -rst drivers/gpu/drm/panel/panel-simple.c > > The warning was: > drivers/gpu/drm/panel/panel-simple.c:42: warning: missing initial short description on line: > * struct panel_desc > > Suggested-by: Sam Ravnborg > Signed-off-by: Douglas Anderson > Cc: Douglas Anderson > Cc: Sam Ravnborg > Cc: Thierry Reding > Cc: dri-devel@lists.freedesktop.org > --- > > drivers/gpu/drm/panel/panel-simple.c | 43 +++++++++++++++++----------- > 1 file changed, 27 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 216cde33b5c4..33d53abdb1fb 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -39,31 +39,36 @@ > #include > > /** > - * struct panel_desc > - * @modes: Pointer to array of fixed modes appropriate for this panel. If > - * only one mode then this can just be the address of this the mode. While applying I fixed this up like this: > - * only one mode then this can just be the address of the mode. Applied to drm-misc-next - thanks for doing this. Much nicer now. Sam