Re: [PATCH 10/10] staging: rtl8723bs: replace unique macros and ELEMENT_ID

Greg KH
2020-12-07T14:12:59Z

On Sat, Dec 05, 2020 at 09:45:17PM -0600, Ross Schmidt wrote:
> Replace unique macros and ELEMENT_ID with kernel provided ieee80211_eid
> enum.
>
> In a several cases multiple macros or constants are replaced by one
> constant.
>
> WLAN_EID_HT_CAP, _HT_CAPABILITY_IE_, and EID_HTCapability are replace by
> WLAN_EID_HT_CAPABILITY.
>
> _WPA2_IE_ID_, EID_WPA2, and _RSN_IE_2_ are replaced by WLAN_EID_RSN.
>
> _HT_EXTRA_INFO_IE_ and _HT_ADD_INFO_IE_ are replaced by
> WLAN_EID_HT_OPERATION.
>
> WLAN_EID_GENERIC, _WPA_IE_ID_, _SSN_IE_1_, and _VENDOR_SPECIFIC_IE_ are
> replaced by WLAN_EID_VENDOR_SPECIFIC.
>
> Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com>

All other patches in this series applied cleanly, please rebase this one
and resend.

You might want to break it up into one-patch-per-constant replacement

thanks,

greg k-h