From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AA20C4361B for ; Mon, 7 Dec 2020 10:44:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57EF323339 for ; Mon, 7 Dec 2020 10:44:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726719AbgLGKoF (ORCPT ); Mon, 7 Dec 2020 05:44:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbgLGKoE (ORCPT ); Mon, 7 Dec 2020 05:44:04 -0500 X-Greylist: delayed 1455 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 07 Dec 2020 02:43:24 PST Received: from tartarus.angband.pl (tartarus.angband.pl [IPv6:2001:41d0:602:dbe::8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07946C0613D4 for ; Mon, 7 Dec 2020 02:43:24 -0800 (PST) Received: from kilobyte by tartarus.angband.pl with local (Exim 4.92) (envelope-from ) id 1kmDbk-0003Gv-1N; Mon, 07 Dec 2020 11:19:04 +0100 Date: Mon, 7 Dec 2020 11:19:04 +0100 From: Adam Borowski To: Greg Kroah-Hartman Cc: Jiri Slaby , Jann Horn , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: Remove dead termiox code Message-ID: <20201207101904.GC2265@angband.pl> References: <20201203020331.2394754-1-jannh@google.com> <5cca5126-60ba-d123-0f7d-47fdbac4c4db@kernel.org> <93834a92-b342-aaee-c400-2883d5df0cdc@kernel.org> <8e993706-46e2-cbed-265f-1ba63cc9274d@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Junkbait: aaron@angband.pl, zzyx@angband.pl User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: kilobyte@angband.pl X-SA-Exim-Scanned: No (on tartarus.angband.pl); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 04, 2020 at 10:10:16AM +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 04, 2020 at 09:51:07AM +0100, Jiri Slaby wrote: > > > > > On Fri, Dec 04, 2020 at 08:22:41AM +0100, Jiri Slaby wrote: > > > > > > On 03. 12. 20, 3:03, Jann Horn wrote: > > > > > > > Delete this dead code; but leave the definition of struct termiox in the > > > > > > > UAPI headers intact. [was snipped] > > > > > > I am thinking -- can/should we mark the structure as deprecated so that > > > > > > userspace stops using it eventually? > > Note this ^^^^^. He is talking about _not_ touching the definition in the > > UAPI header. Does the rest below makes more sense now? > > No, I'm still confused :) > > We can't touch the UAPI definitions, but the fact that this api never > did anything still is ok as after this patch it continues to not do > anything. > > I'm confused as to what you are proposing... The UAPI definition can't be removed, but it would be nice to issue a compiler _warning_ if it's ever used. Like eg. __attribute__ ((deprecated)) Meow! -- ⢀⣴⠾⠻⢶⣦⠀ .--[ Makefile ] ⣾⠁⢠⠒⠀⣿⡁ # beware of races ⢿⡄⠘⠷⠚⠋⠀ all: pillage burn ⠈⠳⣄⠀⠀⠀⠀ `----