From: Christian Brauner <christian.brauner@ubuntu.com>
To: Jann Horn <jannh@google.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH pidfd] signal: Add missing __user annotation to copy_siginfo_from_user_any
Date: Mon, 7 Dec 2020 11:32:30 +0100 [thread overview]
Message-ID: <20201207103230.inx52blkask3662j@wittgenstein> (raw)
In-Reply-To: <20201207000252.138564-1-jannh@google.com>
On Mon, Dec 07, 2020 at 01:02:52AM +0100, Jann Horn wrote:
> copy_siginfo_from_user_any() takes a userspace pointer as second
> argument; annotate the parameter type accordingly.
>
> Signed-off-by: Jann Horn <jannh@google.com>
> ---
> I'm messing around with clang's version of __user annotation checking
> and it spotted this issue:
>
> kernel/signal.c:3759:44: warning: casting to dereferenceable pointer removes 'noderef' attribute [-Wnoderef]
> ret = copy_siginfo_from_user_any(&kinfo, info);
> ^~~~
> Untracked cast to function pointer at kernel/signal.c:4294:26
>
>
> Christian, since this is pidfd code, can you take this through your tree?
> Or should I send this to akpm (or someone else)?
I'm picking it up now. :) Thanks!
Christian
prev parent reply other threads:[~2020-12-07 10:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 0:02 [PATCH pidfd] signal: Add missing __user annotation to copy_siginfo_from_user_any Jann Horn
2020-12-07 10:32 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207103230.inx52blkask3662j@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox