From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7979DC4361B for ; Mon, 7 Dec 2020 13:30:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4583C23407 for ; Mon, 7 Dec 2020 13:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726524AbgLGNaS (ORCPT ); Mon, 7 Dec 2020 08:30:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:47473 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726076AbgLGNaS (ORCPT ); Mon, 7 Dec 2020 08:30:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607347731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HmPG+N5jTzzRdIL5s1TNf9yxVHZKpWeydP8k3ZEKz4U=; b=cRkh5x94hpySf7qp4sQp9P5qw4WwYFmWCOi/W8lVSsdjDRQ77U0AIj/w2p+upOlBnFycoC 1cGKqJVW86Ml4Yv3pHezaNyXajnvZxJd32gcDb6bKCZMwSXx+eCoZXc1OR+RMQg7bqUGiB Shhhrv/roL8U4ss/cRwmwmECPDXUflI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-480-QPyZHp8YPHuq4piMgHAKvg-1; Mon, 07 Dec 2020 08:28:47 -0500 X-MC-Unique: QPyZHp8YPHuq4piMgHAKvg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 929421934100; Mon, 7 Dec 2020 13:28:45 +0000 (UTC) Received: from krava (unknown [10.40.195.101]) by smtp.corp.redhat.com (Postfix) with SMTP id 6D23D10016FB; Mon, 7 Dec 2020 13:28:41 +0000 (UTC) Date: Mon, 7 Dec 2020 14:28:40 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Chanho Park , Will Deacon , Chanho Park , mathieu.poirier@linaro.org, suzuki.poulose@arm.com, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel , Mike Leach , Leo Yan , John Garry , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Khem Raj Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc Message-ID: <20201207132840.GA4070632@krava> References: <20201206144527.1670483-1-chanho61.park@samsung.com> <20201207105359.GA4198@willie-the-truck> <001101d6cc90$3b491310$b1db3930$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 07, 2020 at 09:31:06PM +0900, Namhyung Kim wrote: > Hi Chanho, > > On Mon, Dec 7, 2020 at 8:58 PM Chanho Park wrote: > > > > Hi Will, > > > > > Looks like other files just include this unconditionally, but have a > > > comment explaining why. See util/branch.h and util/event.h. Maybe we > > > should do the same for util/pmu.h, which is already included here? > > > > I found below files which perf includes . Instead of > > doing same for all, we'd better put this only for > > tools/include/uapi/linux/perf_event.h. > > It's a copy of the kernel header, I'm not sure we want to add something there. right, we want to copy that directly from kernel uapi so let's not do any changes in here jirka