Re: [PATCH] arm64: cpufeature: fix unused function warning

Will Deacon
2020-12-04T10:00:13Z

On Thu, Dec 03, 2020 at 11:32:11PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The __system_matches_cap() function is now only used in an #ifdef
> section:
>
> arch/arm64/kernel/cpufeature.c:2649:13: error: unused function '__system_matches_cap' [-Werror,-Wunused-function]
>
> Move it into that #ifdef section.
>
> Fixes: 7cf283c7bd62 ("arm64: uaccess: remove redundant PAN toggling")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm64/kernel/cpufeature.c | 36 ++++++++++++++++------------------
> 1 file changed, 17 insertions(+), 19 deletions(-)

Acked-by: Will Deacon <will@kernel.org>

We can probably go further and remove the helper altogether as I don't
think it really helps has_generic_auth(), but this should fix the warning.

Will