From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH next v2 2/3] printk: change @clear_seq to atomic64_t
Date: Wed, 9 Dec 2020 10:04:03 +0900 [thread overview]
Message-ID: <20201209010403.GC1667627@google.com> (raw)
In-Reply-To: <875z5c9bhn.fsf@jogness.linutronix.de>
On (20/12/08 23:36), John Ogness wrote:
> On 2020-12-09, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> >> Sigh, atomic64_read() uses a spin lock in the generic implementation
> >> that is used on some architectures.
> >
> > Oh... So on those archs prb is not lockless in fact, it actually
> > takes the spin_lock each time we read the descriptor state?
> >
> > desc_read()
> > atomic_long_read(state_var)
> > atomic64_read()
> > raw_spin_lock_irqsave(lock, flags)
> > << NMI panic >>
> >
> > Am I missing something?
>
> For the state variable we chose atomic_long_t instead of atomic64_t for
> this reason. atomic_long_t operations are available atomically on all
> architectures.
Right. Looking more at Kconfigs, it seems that when atomic_long_t is
atomic64 (64BIT) then GENERIC_ATOMIC64 is not selected. Those archs
that select GENERIC_ATOMIC64 unconditionally all seem to be 32-bit.
Thanks.
-ss
next prev parent reply other threads:[~2020-12-09 1:05 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 20:53 [PATCH next v2 0/3] printk: remove logbuf_lock John Ogness
2020-12-01 20:53 ` [PATCH next v2 1/3] printk: inline log_output(),log_store() in vprintk_store() John Ogness
2020-12-03 15:57 ` Petr Mladek
2020-12-03 16:25 ` John Ogness
2020-12-04 6:13 ` Sergey Senozhatsky
2020-12-04 8:26 ` Petr Mladek
2020-12-01 20:53 ` [PATCH next v2 2/3] printk: change @clear_seq to atomic64_t John Ogness
2020-12-04 9:12 ` Petr Mladek
2020-12-06 20:23 ` John Ogness
2020-12-07 9:34 ` Peter Zijlstra
2020-12-07 10:03 ` John Ogness
2020-12-07 12:56 ` Peter Zijlstra
2020-12-07 12:56 ` Petr Mladek
2020-12-07 16:46 ` David Laight
2020-12-08 20:34 ` Sergey Senozhatsky
2020-12-08 22:30 ` John Ogness
2020-12-09 1:04 ` Sergey Senozhatsky [this message]
2020-12-09 8:16 ` Peter Zijlstra
2020-12-09 9:22 ` Sergey Senozhatsky
2020-12-09 10:46 ` Sergey Senozhatsky
2020-12-09 11:00 ` Peter Zijlstra
2020-12-09 11:28 ` Sergey Senozhatsky
2020-12-09 12:29 ` Peter Zijlstra
2020-12-09 8:07 ` Peter Zijlstra
2020-12-01 20:53 ` [PATCH next v2 3/3] printk: remove logbuf_lock, add syslog_lock John Ogness
2020-12-04 6:41 ` Sergey Senozhatsky
2020-12-06 20:44 ` John Ogness
2020-12-04 15:52 ` devkmsg: was " Petr Mladek
2020-12-06 20:51 ` John Ogness
2020-12-07 9:56 ` Petr Mladek
2020-12-04 15:57 ` syslog: was: " Petr Mladek
2020-12-06 21:06 ` John Ogness
2020-12-07 10:01 ` Petr Mladek
2020-12-04 16:10 ` recursion handling: " Petr Mladek
2020-12-05 4:25 ` Sergey Senozhatsky
2020-12-06 22:08 ` John Ogness
2020-12-05 9:41 ` Sergey Senozhatsky
2020-12-06 22:17 ` John Ogness
2020-12-06 21:44 ` John Ogness
2020-12-07 11:17 ` Petr Mladek
2020-12-04 16:15 ` vprintk_store: was: " Petr Mladek
2020-12-06 22:30 ` John Ogness
2020-12-07 12:46 ` Petr Mladek
2020-12-04 16:19 ` consoles: " Petr Mladek
2020-12-05 4:39 ` Sergey Senozhatsky
2020-12-07 9:50 ` Petr Mladek
2020-12-08 20:51 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209010403.GC1667627@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox